Skip to content

Commit a639b2e

Browse files
committed
fix(rivetkit-napi): vendor openssl on all linux targets
The prior arm64-gnu-only scope still left linux-x64-gnu dynamically linked to libssl.so.1.1 from the bullseye builder base, breaking consumers on Debian 12+ / Ubuntu 22.04+ / any host without OpenSSL 1.1. Widen to all linux targets so the .node has no runtime libssl dependency.
1 parent 3823a5f commit a639b2e

2 files changed

Lines changed: 20 additions & 5 deletions

File tree

Cargo.lock

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rivetkit-typescript/packages/rivetkit-napi/Cargo.toml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,13 @@ napi-build = "2"
3333
[dev-dependencies]
3434
serde_bare.workspace = true
3535

36-
# Force vendored openssl for the aarch64-linux-gnu cross build. The linux-gnu
37-
# builder image ships x86_64 libssl-dev only, so transitive openssl-sys (via
38-
# reqwest/native-tls pulled in by opentelemetry-http) cannot find arm64 headers
39-
# through pkg-config. Vendoring compiles openssl from source instead.
40-
[target.'cfg(all(target_arch = "aarch64", target_env = "gnu"))'.dependencies]
36+
# Statically link openssl on all Linux targets. transitive openssl-sys (via
37+
# reqwest/native-tls pulled in by opentelemetry-http) would otherwise pick up
38+
# whatever libssl the builder image happens to ship, and the resulting `.node`
39+
# inherits a NEEDED libssl.so.X runtime dependency that breaks on hosts with a
40+
# different openssl (e.g. linking to libssl.so.1.1 on Debian bullseye breaks on
41+
# Debian bookworm / Ubuntu 22.04+). Vendoring compiles openssl from source and
42+
# static-links it into the addon. darwin uses Security.framework and windows
43+
# uses schannel, so they don't need this.
44+
[target.'cfg(target_os = "linux")'.dependencies]
4145
openssl = { version = "0.10", features = ["vendored"] }

0 commit comments

Comments
 (0)