Skip to content

Commit b8a3dc6

Browse files
committed
feat: US-014 - Document global cache delta in parse_bridge_rivet_error test
1 parent 7b630d8 commit b8a3dc6

3 files changed

Lines changed: 11 additions & 2 deletions

File tree

rivetkit-typescript/packages/rivetkit-wasm/src/lib.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2816,6 +2816,8 @@ mod tests {
28162816

28172817
#[test]
28182818
fn parse_bridge_rivet_error_reuses_interned_schema() {
2819+
// This test owns the `(wasm_schema_cache_test, same_payload)` cache key so
2820+
// concurrent tests do not perturb the global schema-count delta.
28192821
let initial_count = BRIDGE_RIVET_ERROR_SCHEMAS.len();
28202822
let reason = bridge_reason(
28212823
"wasm_schema_cache_test",

scripts/ralph/prd.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,8 +227,8 @@
227227
"Tests pass"
228228
],
229229
"priority": 14,
230-
"passes": false,
231-
"notes": ""
230+
"passes": true,
231+
"notes": "Added a comment documenting the dedicated `(wasm_schema_cache_test, same_payload)` cache namespace used by the global schema-count delta assertion."
232232
}
233233
]
234234
}

scripts/ralph/progress.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,3 +154,10 @@ Started: Sat May 2 02:13:32 AM PDT 2026
154154
- Wasm websocket callback region allocation preserves the existing `u32` JS surface and uses `0` as the untracked sentinel for the impossible exhausted-ID case.
155155
- Tests that assert wraparound should keep an existing low region ID live so the allocator proves it skips active IDs after wrapping.
156156
---
157+
## 2026-05-02 03:34:47 PDT - US-014
158+
- Documented that `parse_bridge_rivet_error_reuses_interned_schema` owns the `(wasm_schema_cache_test, same_payload)` cache key so global schema-count delta assertions remain stable under concurrent tests.
159+
- Files changed: `rivetkit-typescript/packages/rivetkit-wasm/src/lib.rs`, `scripts/ralph/prd.json`, `scripts/ralph/progress.txt`.
160+
- Checks: `cargo test -p rivetkit-wasm --target wasm32-unknown-unknown --no-run parse_bridge_rivet_error_reuses_interned_schema`, `pnpm --filter @rivetkit/rivetkit-wasm run check:package`, `pnpm --filter @rivetkit/rivetkit-wasm run check-types`, `pnpm --filter @rivetkit/rivetkit-wasm run check:wasm`.
161+
- **Learnings for future iterations:**
162+
- Existing Codebase Patterns already cover unique `(group, code)` namespaces for global wasm schema-cache length assertions.
163+
---

0 commit comments

Comments
 (0)