chore: temporarily disable sentry#2406
Closed
NathanFlurry wants to merge 1 commit intomainfrom
Closed
Conversation
Deploying rivet-studio with
|
| Latest commit: |
e029e29
|
| Status: | ⚡️ Build in progress... |
Member
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 26, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Temporarily disables Sentry error tracking and PostHog telemetry functionality in the Rivet CLI tool for simplified standalone builds.
- Commented out Sentry initialization and configuration in
/packages/toolchain/cli/src/main.rs - Disabled Sentry feature flags and dependencies in
/packages/toolchain/cli/Cargo.toml - Modified error reporting function to accept unused
_errparameter while maintaining basic error handling - Preserved core CLI functionality and exit code logic while removing monitoring capabilities
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
|
||
| async fn report_error(err: anyhow::Error) { | ||
| let event_id = sentry::integrations::anyhow::capture_anyhow(&err); | ||
| async fn report_error(_err: anyhow::Error) { |
There was a problem hiding this comment.
style: report_error function is now a no-op but still being called on line 71, consider removing the call entirely if error reporting is disabled
Suggested change
| async fn report_error(_err: anyhow::Error) { | |
| // This is an internal error, report error | |
| eprintln!("\n{err}"); |
Deploying rivet-hub with
|
| Latest commit: |
528ebcb
|
| Status: | 🚫 Build failed. |
Deploying rivet with
|
| Latest commit: |
528ebcb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2c2b111f.rivet.pages.dev |
| Branch Preview URL: | https://graphite-base-2407.rivet.pages.dev |
NathanFlurry
changed the base branch from
04-26-chore_add_standalone_toolchain_build_scripts
to
graphite-base/2406
NathanFlurry
force-pushed
the
graphite-base/2406
branch
from
78080b4 to
ff549fe
Compare
NathanFlurry
force-pushed
the
04-26-chore_temporarily_disable_sentry
branch
from
528ebcb to
e029e29
Compare
Contributor
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Apr 26, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes