refactor: replace unsafe File::from_raw_fd with safe File::from#2479
Closed
NathanFlurry wants to merge 1 commit intomainfrom
Closed
refactor: replace unsafe File::from_raw_fd with safe File::from#2479NathanFlurry wants to merge 1 commit intomainfrom
NathanFlurry wants to merge 1 commit intomainfrom
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves safety by replacing unsafe std::fs::File::from_raw_fd calls with safe std::fs::File::from in packages/edge/infra/client/isolate-v8-runner/src/isolate.rs when handling pipe file descriptors.
- Replaces unsafe
File::from_raw_fdwith safeFile::fromfor stdout and stderr pipe handling - Maintains identical functionality while eliminating unsafe code blocks
- Change is focused on pipe file descriptor management in the isolate runner
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
NathanFlurry
force-pushed
the
refactor_replace_unsafe_File_from_raw_fd_with_safe_File_from
branch
from
bb17add to
6d7e7f9
Compare
Deploying rivet-studio with
|
| Latest commit: |
ac3d4cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://27d1f46c.rivet-studio.pages.dev |
| Branch Preview URL: | https://refactor-replace-unsafe-file.rivet-studio.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
ac3d4cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c3929cd9.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://refactor-replace-unsafe-file.rivet-hub-7jb.pages.dev |
Deploying rivet with
|
| Latest commit: |
ac3d4cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d7675ba3.rivet.pages.dev |
| Branch Preview URL: | https://refactor-replace-unsafe-file.rivet.pages.dev |
NathanFlurry
force-pushed
the
refactor_replace_unsafe_File_from_raw_fd_with_safe_File_from
branch
from
6d7e7f9 to
f093d49
Compare
This was referenced May 30, 2025
This was referenced May 31, 2025
Closed
This was referenced May 31, 2025
MasterPtato
force-pushed
the
refactor_replace_unsafe_File_from_raw_fd_with_safe_File_from
branch
from
f093d49 to
ac3d4cd
Compare
NathanFlurry
force-pushed
the
refactor_replace_unsafe_File_from_raw_fd_with_safe_File_from
branch
from
ac3d4cd to
e35c673
Compare
This was referenced Jun 2, 2025
MasterPtato
force-pushed
the
refactor_replace_unsafe_File_from_raw_fd_with_safe_File_from
branch
from
e35c673 to
ac3d4cd
Compare
Contributor
Merge activity
|
graphite-app
Bot
deleted the
refactor_replace_unsafe_File_from_raw_fd_with_safe_File_from
branch
This was referenced Jun 3, 2025
Closed
This was referenced Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes