chore: expose namespace in otel attributes#2501
chore: expose namespace in otel attributes#2501NathanFlurry wants to merge 1 commit into04-26-chore_add_standalone_toolchain_build_scriptsfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Adds namespace information to OpenTelemetry attributes across multiple components for better service observability and monitoring.
- Added
RIVET_NAMESPACEto OpenTelemetry resource attributes in/packages/common/runtime/src/otel.rs - Implemented namespace tagging in Vector configuration for metrics and logs across all pool types in
/packages/core/services/cluster/src/workflows/server/install/install_scripts/components/vector.rs - Added
RIVET_NAMESPACEenvironment variable to both worker and guard systemd service configurations - Modified
gen_initializefunction to pass namespace information to Vector configuration consistently
7 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| r#" | ||
| .source = "pegboard_manager" | ||
|
|
||
| .namespace = "{namespace}" |
There was a problem hiding this comment.
style: Namespace field added at root level for pegboard logs, while metrics use .tags.namespace. Consider using consistent structure
| Environment="RIVET_OTEL_ENABLED=1" | ||
| Environment="RIVET_OTEL_SAMPLER_RATIO=1" | ||
| Environment="RIVET_SERVICE_NAME=edge" | ||
| Environment="RIVET_NAMESPACE=__NAMESPACE__" |
There was a problem hiding this comment.
style: Ensure NAMESPACE is properly replaced during configuration. The template variable format differs from other environment variables which use ___ prefix/suffix.
| Environment="RIVET_OTEL_ENABLED=1" | ||
| Environment="RIVET_OTEL_SAMPLER_RATIO=1" | ||
| Environment="RIVET_SERVICE_NAME=guard" | ||
| Environment="RIVET_NAMESPACE=__NAMESPACE__" |
There was a problem hiding this comment.
style: Template variable uses different underscore pattern than other environment variables (NAMESPACE vs CLUSTER_ID). Should be consistent with 3 underscores.
| Environment="RIVET_NAMESPACE=__NAMESPACE__" | |
| Environment="RIVET_NAMESPACE=___NAMESPACE___" |
Deploying rivet with
|
| Latest commit: |
7b38fd6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a113fc2d.rivet.pages.dev |
| Branch Preview URL: | https://05-30-chore-expose-namespace.rivet.pages.dev |
NathanFlurry
changed the base branch from
05-30-chore_pegboard_update_oci_config_for_stricter_security
to
graphite-base/2501
NathanFlurry
force-pushed
the
graphite-base/2501
branch
from
d4c8eac to
fa70169
Compare
NathanFlurry
force-pushed
the
05-30-chore_expose_namespace_in_otel_attributes
branch
from
049ebae to
8f8d1e6
Compare
NathanFlurry
changed the base branch from
graphite-base/2501
to
04-26-chore_add_standalone_toolchain_build_scripts
Deploying rivet-hub with
|
| Latest commit: |
7b38fd6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://28f602af.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://05-30-chore-expose-namespace.rivet-hub-7jb.pages.dev |
Deploying rivet-studio with
|
| Latest commit: |
7b38fd6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://20102259.rivet-studio.pages.dev |
| Branch Preview URL: | https://05-30-chore-expose-namespace.rivet-studio.pages.dev |
MasterPtato
force-pushed
the
05-30-chore_expose_namespace_in_otel_attributes
branch
from
8f8d1e6 to
7b38fd6
Compare
NathanFlurry
force-pushed
the
05-30-chore_expose_namespace_in_otel_attributes
branch
from
7b38fd6 to
3115384
Compare
NathanFlurry
force-pushed
the
04-26-chore_add_standalone_toolchain_build_scripts
branch
from
2c043a5 to
0c27195
Compare
graphite-app
Bot
deleted the
05-30-chore_expose_namespace_in_otel_attributes
branch
1 participant
Changes