fix(pegboard): continue exporting metrics even if fetching actor fails#2520
Closed
Conversation
This was referenced Jun 2, 2025
Member
Author
This was referenced Jun 2, 2025
Closed
This was referenced Jun 2, 2025
Deploying rivet with
|
| Latest commit: |
3e0b88b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6e009397.rivet.pages.dev |
| Branch Preview URL: | https://05-31-fix-pegboard-continue.rivet.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
3e0b88b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae06cb93.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://05-31-fix-pegboard-continue.rivet-hub-7jb.pages.dev |
Deploying rivet-studio with
|
| Latest commit: |
3e0b88b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23f004ab.rivet-studio.pages.dev |
| Branch Preview URL: | https://05-31-fix-pegboard-continue.rivet-studio.pages.dev |
MasterPtato
force-pushed
the
05-31-fix_pegboard_fix_collecting_metrics_for_actors_without_workflows
branch
from
dff268d to
4527a1a
Compare
MasterPtato
force-pushed
the
05-31-fix_pegboard_continue_exporting_metrics_even_if_fetching_actor_fails
branch
from
a6a6179 to
3e0b88b
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhances error handling in the pegboard metrics collection service to ensure continuous metrics export even when actor fetches fail. The changes introduce an allow_errors parameter across multiple components.
- Added
allow_errors: trueinpegboard/standalone/usage-metrics-publish/src/lib.rsto continue metrics collection despite actor fetch failures - Implemented strict error handling (
allow_errors: false) in actor API endpoints to maintain data integrity - Added error handling logic in
pegboard_actor_getoperation to log warnings and continue processing whenallow_errorsis true - Modified actor fetching stream to handle failures gracefully while maintaining metrics collection for available actors
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| /// path endpoint. | ||
| pub endpoint_type: Option<crate::types::EndpointType>, | ||
|
|
||
| pub allow_errors: bool, |
There was a problem hiding this comment.
style: Missing documentation for allow_errors field to explain when it should be used and potential implications.
Suggested change
| pub allow_errors: bool, | |
| /// When true, errors fetching individual actors will be logged and skipped instead of failing the entire operation. | |
| /// This is useful for bulk operations where partial failures are acceptable. | |
| pub allow_errors: bool, |
Contributor
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
#2520) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
Bot
deleted the
05-31-fix_pegboard_continue_exporting_metrics_even_if_fetching_actor_fails
branch
This was referenced Jun 3, 2025
This was referenced Jun 4, 2025
Closed
This was referenced Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes