fix(pegboard): increase signal timeout, add check for actor exit by MasterPtato · Pull Request #2538 · rivet-dev/rivet

MasterPtato · 2025-06-04T19:08:12Z

Changes

cloudflare-workers-and-pages · 2025-06-04T19:08:14Z

Deploying rivet-studio with Cloudflare Pages

Latest commit:	`3b1c588`
Status:	✅ Deploy successful!
Preview URL:	https://199c1912.rivet-studio.pages.dev
Branch Preview URL:	https://06-04-fix-pegboard-increase.rivet-studio.pages.dev

View logs

MasterPtato · 2025-06-04T19:08:55Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

PR Summary

Enhances pegboard system's actor management and image prewarming with focus on signal handling and timeout improvements.

Increased STOP_PID_RETRIES from 32 to 1024 in packages/edge/infra/client/manager/src/actor/mod.rs for longer actor stop timeout
Added actor exit check in signal handling to prevent unnecessary PID wait cycles
Modified prewarm_image in packages/edge/infra/client/manager/src/utils/mod.rs to handle prewarming asynchronously with Arc<Ctx>
Reduced log spam by only showing progress every 10 retries during actor stop process
Simplified image prewarming in packages/edge/infra/client/manager/src/ctx.rs by removing unnecessary task spawning

_{3 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-06-04T19:08:57Z

 			protocol::ToClient::PrewarmImage {
 				image_id,
 				image_artifact_url_stub,
-			} => {
-				let self2 = self.clone();
-
-				tokio::spawn(async move {
-					utils::prewarm_image(&self2, image_id, &image_artifact_url_stub).await
-				});
-			}
+			} => utils::prewarm_image(&self, image_id, &image_artifact_url_stub),
 		}


logic: Consider adding .await to the utils::prewarm_image call since it's an async function

Suggested change

protocol::ToClient::PrewarmImage {

image_id,

image_artifact_url_stub,

} => {

let self2 = self.clone();

tokio::spawn(async move {

utils::prewarm_image(&self2, image_id, &image_artifact_url_stub).await

});

}

} => utils::prewarm_image(&self, image_id, &image_artifact_url_stub),

}

protocol::ToClient::PrewarmImage {

image_id,

image_artifact_url_stub,

} => utils::prewarm_image(&self, image_id, &image_artifact_url_stub).await?,

cloudflare-workers-and-pages · 2025-06-04T19:11:41Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`3b1c588`
Status:	✅ Deploy successful!
Preview URL:	https://afb57b1c.rivet-hub-7jb.pages.dev
Branch Preview URL:	https://06-04-fix-pegboard-increase.rivet-hub-7jb.pages.dev

View logs

cloudflare-workers-and-pages · 2025-06-04T19:11:42Z

Deploying rivet with Cloudflare Pages

Latest commit:	`3b1c588`
Status:	✅ Deploy successful!
Preview URL:	https://e6ea7fd5.rivet.pages.dev
Branch Preview URL:	https://06-04-fix-pegboard-increase.rivet.pages.dev

View logs

graphite-app · 2025-06-09T16:46:59Z

Merge activity

Jun 9, 4:46 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
Jun 9, 4:48 PM UTC: CI is running for this pull request on a draft pull request (#2574) due to your merge queue CI optimization settings.
Jun 9, 4:49 PM UTC: Merged by the Graphite merge queue via draft PR: #2574.

## Changes

MasterPtato requested a review from NathanFlurry June 4, 2025 19:08

This was referenced Jun 4, 2025

fix(pegboard): wait for actor allocation not creation #2539

Closed

Fix(guard): return error response on router error #2540

Closed

greptile-apps Bot reviewed Jun 4, 2025

View reviewed changes

MasterPtato force-pushed the 06-04-fix_pegboard_revise_actor_rescheduling_algorithm_add_client_metrics branch from f9ef2e7 to a52399a Compare June 4, 2025 19:17

MasterPtato force-pushed the 06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit branch from 4f69969 to a38c8f3 Compare June 4, 2025 19:17

This was referenced Jun 4, 2025

feat(clusters): add margin per pool #2543

Closed

fix(pegboard): increase actor log ttl to 14 days #2544

Closed

chore(vector): add vector pipeline to ship clickhouse events from the edge #2526

Closed

NathanFlurry force-pushed the 06-04-fix_pegboard_revise_actor_rescheduling_algorithm_add_client_metrics branch from a52399a to 6f7c837 Compare June 5, 2025 00:58

NathanFlurry force-pushed the 06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit branch from a38c8f3 to 100bf59 Compare June 5, 2025 00:58

MasterPtato force-pushed the 06-04-fix_pegboard_revise_actor_rescheduling_algorithm_add_client_metrics branch from 6f7c837 to ec71a65 Compare June 5, 2025 02:10

MasterPtato force-pushed the 06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit branch from 100bf59 to 5517494 Compare June 5, 2025 02:10

This was referenced Jun 5, 2025

chore: fix dc wf #2552

Closed

fix: add vector http config to edge configs #2553

Closed

fix(pegboard): increase signal timeout, add check for actor exit

3b1c588

MasterPtato force-pushed the 06-04-fix_pegboard_revise_actor_rescheduling_algorithm_add_client_metrics branch from ec71a65 to bbbf37e Compare June 6, 2025 01:36

MasterPtato force-pushed the 06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit branch from 5517494 to 3b1c588 Compare June 6, 2025 01:36

graphite-app Bot closed this Jun 9, 2025

graphite-app Bot deleted the 06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit branch June 9, 2025 16:49

github-actions Bot mentioned this pull request Jun 9, 2025

chore(main): release 25.5.1 #2423

Merged

MasterPtato mentioned this pull request Jun 9, 2025

fix(pegboard): fix container runner orphaning #2575

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(pegboard): increase signal timeout, add check for actor exit#2538

fix(pegboard): increase signal timeout, add check for actor exit#2538
MasterPtato wants to merge 1 commit into06-04-fix_pegboard_revise_actor_rescheduling_algorithm_add_client_metricsfrom
06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit

MasterPtato commented Jun 4, 2025

Uh oh!

cloudflare-workers-and-pages Bot commented Jun 4, 2025 •

edited

Loading

Uh oh!

MasterPtato commented Jun 4, 2025 •

edited

Loading

Uh oh!

greptile-apps Bot left a comment

Uh oh!

greptile-apps Bot Jun 4, 2025

Uh oh!

cloudflare-workers-and-pages Bot commented Jun 4, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented Jun 4, 2025 •

edited

Loading

Uh oh!

graphite-app Bot commented Jun 9, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

MasterPtato commented Jun 4, 2025

Changes

Uh oh!

cloudflare-workers-and-pages Bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-studio with Cloudflare Pages

Uh oh!

MasterPtato commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps Bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

cloudflare-workers-and-pages Bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-hub with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages Bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet with Cloudflare Pages

Uh oh!

graphite-app Bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

cloudflare-workers-and-pages Bot commented Jun 4, 2025 •

edited

Loading

MasterPtato commented Jun 4, 2025 •

edited

Loading

cloudflare-workers-and-pages Bot commented Jun 4, 2025 •

edited

Loading

cloudflare-workers-and-pages Bot commented Jun 4, 2025 •

edited

Loading

graphite-app Bot commented Jun 9, 2025 •

edited

Loading