Skip to content

Fix(guard): return error response on router error#2540

Closed
MasterPtato wants to merge 1 commit into06-04-fix_pegboard_wait_for_actor_allocation_not_creationfrom
06-04-fix_guard_return_error_response_on_router_error
Closed

Fix(guard): return error response on router error#2540
MasterPtato wants to merge 1 commit into06-04-fix_pegboard_wait_for_actor_allocation_not_creationfrom
06-04-fix_guard_return_error_response_on_router_error

Conversation

@MasterPtato
Copy link
Copy Markdown
Contributor

Changes

Copy link
Copy Markdown
Contributor Author

MasterPtato commented Jun 4, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Modified error handling in the guard server's routing logic to return INTERNAL_SERVER_ERROR responses on routing failures instead of attempting fallback routes.

  • Changed create_routing_function in packages/edge/infra/guard/server/src/routing/mod.rs to immediately return errors rather than continuing with fallback routes
  • Improved import formatting in packages/edge/infra/guard/server/src/routing/api.rs for better code readability
  • Potential breaking change: Requests will no longer attempt alternative routing methods if the primary route fails

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jun 4, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 78b6466
Status: ✅  Deploy successful!
Preview URL: https://e17aecdf.rivet.pages.dev
Branch Preview URL: https://06-04-fix-guard-return-error.rivet.pages.dev

View logs

@MasterPtato MasterPtato force-pushed the 06-04-fix_guard_return_error_response_on_router_error branch from 28067bc to b87a3c1 Compare June 4, 2025 19:17
@NathanFlurry NathanFlurry force-pushed the 06-04-fix_guard_return_error_response_on_router_error branch from b87a3c1 to a2b2d0d Compare June 5, 2025 00:58
@NathanFlurry NathanFlurry force-pushed the 06-04-fix_pegboard_wait_for_actor_allocation_not_creation branch from 60de115 to 779cf53 Compare June 5, 2025 00:58
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jun 5, 2025

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 78b6466
Status: ✅  Deploy successful!
Preview URL: https://6b97be24.rivet-studio.pages.dev
Branch Preview URL: https://06-04-fix-guard-return-error.rivet-studio.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jun 5, 2025

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 78b6466
Status: ✅  Deploy successful!
Preview URL: https://4fc93442.rivet-hub-7jb.pages.dev
Branch Preview URL: https://06-04-fix-guard-return-error.rivet-hub-7jb.pages.dev

View logs

@MasterPtato MasterPtato force-pushed the 06-04-fix_guard_return_error_response_on_router_error branch from bf7487c to 78b6466 Compare June 6, 2025 18:29
@MasterPtato MasterPtato force-pushed the 06-04-fix_pegboard_wait_for_actor_allocation_not_creation branch from 6d98c23 to d6aaade Compare June 6, 2025 18:29
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Jun 9, 2025

Merge activity

  • Jun 9, 4:47 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
  • Jun 9, 4:48 PM UTC: CI is running for this pull request on a draft pull request (#2574) due to your merge queue CI optimization settings.
  • Jun 9, 4:49 PM UTC: Merged by the Graphite merge queue via draft PR: #2574.

graphite-app Bot pushed a commit that referenced this pull request Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app Bot closed this Jun 9, 2025
@graphite-app graphite-app Bot deleted the 06-04-fix_guard_return_error_response_on_router_error branch June 9, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant