fix: dont include installing servers in service discovery#2569
Closed
MasterPtato wants to merge 1 commit intomainfrom
Closed
fix: dont include installing servers in service discovery#2569MasterPtato wants to merge 1 commit intomainfrom
MasterPtato wants to merge 1 commit intomainfrom
Conversation
This was referenced Jun 6, 2025
Closed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhances service discovery reliability by filtering out installing servers in datacenters.rs. This prevents premature inclusion of servers that haven't completed installation in the service discovery system.
- Modified
packages/core/api/provision/src/route/datacenters.rsto exclude servers whereinstall_complete_tsis None from service discovery results
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This was referenced Jun 6, 2025
Closed
This was referenced Jun 6, 2025
Contributor
Author
Deploying rivet with
|
| Latest commit: |
1336a33
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b2332e38.rivet.pages.dev |
| Branch Preview URL: | https://graphite-base-2570.rivet.pages.dev |
graphite-app
Bot
changed the base branch from
06-06-fix_pegboard_fix_allocation_metrics
to
graphite-base/2569
MasterPtato
force-pushed
the
06-06-fix_dont_include_installing_servers_in_service_discovery
branch
from
11a498b to
1336a33
Compare
MasterPtato
force-pushed
the
graphite-base/2569
branch
from
b59017e to
9b454d7
Compare
Deploying rivet-studio with
|
| Latest commit: |
1336a33
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://41b481ea.rivet-studio.pages.dev |
| Branch Preview URL: | https://graphite-base-2570.rivet-studio.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
1336a33
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6a09f6d.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://graphite-base-2570.rivet-hub-7jb.pages.dev |
This was referenced Jun 9, 2025
Contributor
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
Bot
deleted the
06-06-fix_dont_include_installing_servers_in_service_discovery
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes