feat: db sh for workflows#2570
Closed
MasterPtato wants to merge 1 commit into06-09-fix_pegboard_fix_enabling_root_usersfrom
Closed
feat: db sh for workflows#2570MasterPtato wants to merge 1 commit into06-09-fix_pegboard_fix_enabling_root_usersfrom
MasterPtato wants to merge 1 commit into06-09-fix_pegboard_fix_enabling_root_usersfrom
Conversation
This was referenced Jun 7, 2025
Closed
Closed
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+243
to
+244
| let db_file = tempfile::NamedTempFile::new()?; | ||
| let db_path = db_file.path(); |
Contributor
There was a problem hiding this comment.
The NamedTempFile is created but its handle is dropped after getting the path, which could cause the file to be deleted prematurely by the OS. Consider storing the file handle in a variable that persists throughout the function's scope to ensure the temporary file remains available until all operations are complete.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
MasterPtato
force-pushed
the
06-09-fix_pegboard_fix_enabling_root_users
branch
from
549dc3f to
2fc41ec
Compare
MasterPtato
force-pushed
the
06-07-feat_db_sh_for_workflows
branch
from
ba62978 to
01bc6a9
Compare
This was referenced Jun 19, 2025
NathanFlurry
force-pushed
the
06-07-feat_db_sh_for_workflows
branch
from
01bc6a9 to
cfc30cf
Compare
This was referenced Jun 20, 2025
MasterPtato
force-pushed
the
06-09-fix_pegboard_fix_enabling_root_users
branch
from
62a55c9 to
e63bad4
Compare
MasterPtato
force-pushed
the
06-07-feat_db_sh_for_workflows
branch
from
cfc30cf to
a3cf488
Compare
NathanFlurry
force-pushed
the
06-07-feat_db_sh_for_workflows
branch
from
a3cf488 to
6ce34ef
Compare
NathanFlurry
force-pushed
the
06-09-fix_pegboard_fix_enabling_root_users
branch
from
e63bad4 to
636f808
Compare
Contributor
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced Jun 20, 2025
Closed
This was referenced Jun 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes