feat(toolchain): remote build logs#2587
Closed
abcxff wants to merge 1 commit into06-11-feat_toolchain_build_args_support_for_remote_buildsfrom
Closed
feat(toolchain): remote build logs#2587abcxff wants to merge 1 commit into06-11-feat_toolchain_build_args_support_for_remote_buildsfrom
abcxff wants to merge 1 commit into06-11-feat_toolchain_build_args_support_for_remote_buildsfrom
Conversation
This was referenced Jun 12, 2025
Contributor
Author
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implements remote build logs functionality by centralizing actor logging in the toolchain library and adding build status tracking for both Docker and Rivet builds.
- Moved actor logging from CLI to toolchain library (
packages/toolchain/toolchain/src/util/actor/logs.rs) with newexit_on_ctrl_ccontrol - Added runner-specific build status tracking in CI manager including new
RunnerSchematypes for rivet, docker, and noRunner - Enhanced
kaniko-runner.tswith build status validation and noRunner data support - Improved build monitoring in
build_remote.rsby replacing static attempt counter with time-based timeout - Centralized base64 dependency in toolchain package for log encoding/decoding
13 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
1e67e85
|
| Status: | 🚫 Build failed. |
abcxff
force-pushed
the
06-11-feat_toolchain_remote_build_logs
branch
from
bcf92bd to
494b927
Compare
Contributor
Author
abcxff
changed the base branch from
06-11-feat_toolchain_build_args_support_for_remote_builds
to
graphite-base/2587
abcxff
force-pushed
the
graphite-base/2587
branch
from
fbbfba0 to
b90675b
Compare
abcxff
force-pushed
the
06-11-feat_toolchain_remote_build_logs
branch
from
494b927 to
1e67e85
Compare
abcxff
changed the base branch from
graphite-base/2587
to
06-11-feat_toolchain_build_args_support_for_remote_builds
Deploying rivet-hub with
|
| Latest commit: |
1e67e85
|
| Status: | 🚫 Build failed. |
Deploying rivet-studio with
|
| Latest commit: |
1e67e85
|
| Status: | 🚫 Build failed. |
abcxff
changed the base branch from
06-11-feat_toolchain_build_args_support_for_remote_builds
to
graphite-base/2587
abcxff
changed the base branch from
graphite-base/2587
to
06-11-feat_toolchain_build_args_support_for_remote_builds
Contributor
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes RVT-4788