fix: driver test suite & sqlite reliability

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[railway-app]

🚅 Deployed to the rivet-pr-4559 environment in rivet-frontend

Service	Status	Web	Updated (UTC)
kitchen-sink	❌ Build Failed (View Logs)	Web	Apr 8, 2026 at 9:08 pm
frontend-cloud	🕒 Building (View Logs)	Web	Apr 8, 2026 at 9:08 pm
frontend-inspector	🕒 Building (View Logs)	Web	Apr 8, 2026 at 9:08 pm
mcp-hub	✅ Success (View Logs)	Web	Apr 5, 2026 at 11:57 am
website	❌ Build Failed (View Logs)	Web	Apr 5, 2026 at 11:57 am
ladle	❌ Build Failed (View Logs)	Web	Apr 5, 2026 at 11:57 am

[NathanFlurry]

• chore: remove non-engine drivers #4574 : 2 dependent PRs (#4581 , #4582 )
• feat: dynamic actors #4397
• fix: driver test suite & sqlite reliability #4559 👈 (View in Graphite)
• fix: remove serverless token #4572
• fix: misc token fixes #4569
• fix(pb): clean up actor stop decision handling #4566
• fix(envoy): use global instance, add signal handlers #4565
• chore: misc fixes, add pb snapshot test #4561
• fix(cache): make in memory cache global #4560
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: fix driver test suite and sqlite reliability

Summary: This PR fixes several correctness bugs and refactors the SQLite/KV channel architecture for reliability. The changes are broadly well-structured. A few items warrant attention before merging.

Bugs Fixed (Confirmed Good)

• pegboard-envoy/src/conn.rs: Correct fix. old_last_ping_ts_entry was reading from create_ts_key instead of last_ping_ts_key. Classic copy-paste bug.
• envoy-client/src/tasks/envoy/index.ts: lostTimeout was never updated because handleConnMessage/handleConnClose returned void. Returning the updated timeout is the right fix.
• actor/conn/mod.ts: Making disconnect() idempotent via disconnectPromise is the correct pattern for preventing double-cleanup races.

Concerns

1. KV channel single-writer guarantee removed (high priority): engine/packages/pegboard-kv-channel/src/lib.rs removes the global KvChannelState struct and the per-actor Mutex locking mechanism entirely. CLAUDE.md states the KV channel enforces single-writer locks per actor. The PR description does not mention this guarantee being intentionally relaxed. If two connections from different processes open the same actor KV channel concurrently, there is no cross-connection exclusion anymore. Please confirm this is intentional and, if so, update the CLAUDE.md invariant accordingly.

2. void actor.processMessage() lost error observability: actor/router-websocket-endpoints.ts now fires action messages with void actor.processMessage() to allow concurrency. Errors thrown by processMessage for actions will be silently swallowed. Consider wrapping with a catch that at minimum logs the error.

3. Legacy KV read path removed without migration check: engine/packages/epoxy/src/ops/kv/read_value.rs removes the legacy v2-format value read case (case 3: v1 subspace with v2 key layout). If any live actors still have data written in this intermediate format, reads will silently return None. Confirm the migration window has fully closed before this ships to production.

4. NativeSqliteDatabase retry count is a magic number: rivetkit-typescript/packages/rivetkit/src/db/native-adapter.ts retries up to 3 times on stale KV channel errors with an inlined check (attempt >= 3). Extract to a named constant MAX_RECONNECT_ATTEMPTS = 3 with a brief comment.

Minor notes: actor/instance/mod.ts span-end fix is subtle but correct; a comment would help future readers. Shared test state in driver-engine.test.ts needs full teardown between test cases to prevent state leakage. turbo.json for sqlite-native is a good addition; verify outputs covers all napi-rs cross-compilation targets. broadcastProcessEvent correctly re-throws non-ActorStopping errors and silently drops ActorStopping.

Overall the PR is headed in the right direction. The KV single-writer question and the legacy read-path removal are the two items most worth validating before merge.

[MasterPtato]

Merge activity

• Apr 8, 8:52 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Apr 8, 9:08 PM UTC: Graphite rebased this pull request as part of a merge.
• Apr 8, 9:09 PM UTC: @MasterPtato merged this pull request with Graphite.