Conversation
|
🚅 Deployed to the rivet-pr-4567 environment in rivet-frontend
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code Review: refactor: icons chunkOverviewThis PR refactors The diff is enormous (334K additions, 151K deletions) but is entirely generated output from the vendor script, not hand-written code. Issues1. Missing The vendor script explicitly creates 2. Repeated esbuild boilerplate inflates the repo significantly Each of the ~3000 icon files is ~67 lines, of which ~58 are identical esbuild CommonJS interop helpers ( 3. No TypeScript declarations for The 4. Package name uses deprecated The package is named Observations
SummaryThe chunking approach is architecturally solid. Two blockers before merging:
The boilerplate repetition and namespace issues are non-blocking but worth a follow-up ticket. |
ae90870 to
ba14ee2
Compare
e46d451 to
48aaa25
Compare
Preview packages published to npmInstall with: npm install rivetkit@pr-4567All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-4c10a30
docker pull rivetdev/engine:full-4c10a30Individual packagesnpm install rivetkit@pr-4567
npm install @rivetkit/react@pr-4567
npm install @rivetkit/rivetkit-native@pr-4567
npm install @rivetkit/sqlite-wasm@pr-4567
npm install @rivetkit/workflow-engine@pr-4567 |
48aaa25 to
6c78503
Compare
ba14ee2 to
d41b1a5
Compare
6c78503 to
d800db9
Compare
d800db9 to
569395b
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: