Skip to content

chore: remove non-engine drivers#4574

Merged
MasterPtato merged 1 commit intomainfrom
04-06-chore_remove_non-engine_drivers
Apr 8, 2026
Merged

chore: remove non-engine drivers#4574
MasterPtato merged 1 commit intomainfrom
04-06-chore_remove_non-engine_drivers

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@claude
Copy link
Copy Markdown

claude bot commented Apr 7, 2026

PR Review: chore: remove non-engine drivers

Summary: This PR removes Cloudflare Workers support across the entire monorepo - examples, driver package, fixtures, marketing pages, and docs - while renaming remote-manager-driver to engine-client. Net result: +832 / -38,373 lines across 384 files.


What changed (beyond the obvious Cloudflare removals)

  • remote-manager-driver to engine-client rename (rivetkit-typescript/packages/rivetkit/src/engine-client/): most files are pure renames; driver.ts drops 48 lines, mod.ts and api-endpoints.ts have minor content updates. This resolves the earlier path question.
  • New file: rivetkit-typescript/packages/rivetkit/src/runtime-router/kv-limits.ts is the only net-new file. Worth confirming it does not duplicate limits in src/drivers/file-system/kv-limits.ts.
  • Fixture removal: all of fixtures/driver-test-suite/actors/ deleted. Tests in src/driver-test-suite/tests/ remain.
  • Marketing page removed: website/src/pages/rivet-vs-cloudflare-workers.astro and sitemap entry deleted. External links to that page will 404.
  • Website docs removed: cloudflare-workers.mdx quickstart and connect pages gone.

Positives

  • Large reduction in maintenance surface: removing ~38K lines of Cloudflare-specific code.
  • Repository URL fix in engine/sdks/typescript/api-full/package.json: corrects rivet-gg/rivet to rivet-dev/rivet per CLAUDE.md.
  • The remote-manager-driver to engine-client rename is a meaningful clarity improvement.
  • vite.config.ts comment fix ("manager API" to "actor API") is correct.

Remaining concerns

1. Empty PR description - No motivation or summary was provided.

2. Rivet-vs-Cloudflare page removal - website/src/pages/rivet-vs-cloudflare-workers.astro was removed without a redirect. Links to it will 404. Consider adding a redirect rule.

3. Internal spec docs still vague - DYNAMIC_ACTORS_ARCHITECTURE.md and DYNAMIC_ACTOR_SQLITE_PROXY_SPEC.md now refer to test directories without concrete paths.

4. Duplicate kv-limits - New src/runtime-router/kv-limits.ts alongside src/drivers/file-system/kv-limits.ts may duplicate limit definitions. If intentionally separate, a brief comment explaining the split would prevent future confusion.


Verdict

Clean removal. The remote-manager-driver to engine-client rename is a good clarity improvement. Main open items post-merge: potential 404 on the removed comparison page and confirming the kv-limits split is intentional.

Copy link
Copy Markdown
Contributor

MasterPtato commented Apr 8, 2026

Merge activity

  • Apr 8, 8:52 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 8, 9:13 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 8, 9:13 PM UTC: @MasterPtato merged this pull request with Graphite.

@MasterPtato MasterPtato changed the base branch from 03-08-feat_rivetkit_dynamic_actors to graphite-base/4574 April 8, 2026 21:10
@MasterPtato MasterPtato changed the base branch from graphite-base/4574 to main April 8, 2026 21:11
@MasterPtato MasterPtato force-pushed the 04-06-chore_remove_non-engine_drivers branch from 28719f8 to 5267c38 Compare April 8, 2026 21:12
@MasterPtato MasterPtato merged commit 0868635 into main Apr 8, 2026
5 of 14 checks passed
@MasterPtato MasterPtato deleted the 04-06-chore_remove_non-engine_drivers branch April 8, 2026 21:13
@MasterPtato MasterPtato mentioned this pull request Apr 9, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants