Skip to content

chore(rivetkit): remove inline tests#4668

Open
NathanFlurry wants to merge 1 commit intobreak-up/subscribe-before-namespace-dispatchfrom
04-15-chore_rivetkit_remove_inline_tests
Open

chore(rivetkit): remove inline tests#4668
NathanFlurry wants to merge 1 commit intobreak-up/subscribe-before-namespace-dispatchfrom
04-15-chore_rivetkit_remove_inline_tests

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 15, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude Bot commented Apr 15, 2026

PR Review: chore(rivetkit): remove inline tests

Summary: Pure deletion PR removing 244 lines across two test files. Both removals are appropriate and the changes are correct.


driver-engine-ping.test.ts (151 lines)

This file contained engine smoke tests (HTTP ping, gateway HTTP, WebSocket echo, gateway WebSocket) using describeDriverMatrix. The coverage is fully superseded by the existing driver test suite:

  • tests/driver/raw-http.test.ts - covers rawHttpActor HTTP GET/POST, including the api/hello assertion
  • tests/driver/raw-websocket.test.ts - covers rawWebSocketActor echo
  • tests/driver/gateway-routing.test.ts + gateway-query-url.test.ts - cover gateway URL routing

The removed file also had a code quality issue worth noting: waitForOpen() was defined as a reusable helper but the first WebSocket test ("WebSocket echo works") duplicated the open-wait logic inline instead of calling it. The existing driver suite does not carry this redundancy.

One difference: the removed file was restricted to { encodings: ["json"] }, whereas the driver matrix tests run across all configured encodings, so the replacement coverage is actually broader.

standalone-ws-sqlite.mts (93 lines)

This was a development/debugging script, not a proper Vitest test. Indicators:

  • .mts extension with a top-of-file comment // Run: npx tsx tests/standalone-ws-sqlite.mts - never wired into automated CI
  • Hardcoded endpoint (http://127.0.0.1:6420), token ("dev"), and console.log with PASS/FAIL markers
  • Misleading filename: despite being named ws-sqlite, the file contains no SQLite tests - only WebSocket and HTTP action tests

Removal is clearly correct.


Minor notes

  • PR title accuracy: "inline tests" in this repo's conventions typically refers to Rust #[cfg(test)] mod tests blocks inside src/. These are standalone files in tests/ - "remove redundant driver smoke tests" or "remove ad-hoc test scripts" would be more precise.
  • Empty description: The PR description is just the template with no explanation of why the tests are being removed or that coverage exists elsewhere. A one-liner noting the superseding test files would help future readers understand the intent.

Verdict: Approve. Both deletions are correct, coverage is intact, and the net result is a cleaner test directory.

@NathanFlurry NathanFlurry changed the base branch from break-up/serialize-gateway-actor-keys to graphite-base/4668 April 27, 2026 05:57
@NathanFlurry NathanFlurry force-pushed the 04-15-chore_rivetkit_remove_inline_tests branch from efc5411 to 22e1c37 Compare April 27, 2026 05:57
@NathanFlurry NathanFlurry changed the base branch from graphite-base/4668 to break-up/subscribe-before-namespace-dispatch April 27, 2026 05:57
@NathanFlurry NathanFlurry marked this pull request as ready for review April 27, 2026 06:38
@NathanFlurry NathanFlurry force-pushed the break-up/subscribe-before-namespace-dispatch branch from c142d37 to 9cff91c Compare April 27, 2026 07:08
@NathanFlurry NathanFlurry force-pushed the 04-15-chore_rivetkit_remove_inline_tests branch from 22e1c37 to 120eb41 Compare April 27, 2026 07:08
@NathanFlurry NathanFlurry force-pushed the break-up/subscribe-before-namespace-dispatch branch from 9cff91c to 4d2fafe Compare April 27, 2026 07:30
@NathanFlurry NathanFlurry force-pushed the 04-15-chore_rivetkit_remove_inline_tests branch from 120eb41 to 3e71f86 Compare April 27, 2026 07:31
@NathanFlurry NathanFlurry force-pushed the 04-15-chore_rivetkit_remove_inline_tests branch from 3e71f86 to 9f86a95 Compare April 27, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant