refactor(rivetkit): move devtools to local script#4669
refactor(rivetkit): move devtools to local script#4669jog1t wants to merge 1 commit intographite-base/4669from
Conversation
|
🚅 Deployed to the rivet-pr-4669 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Preview packages published to npmInstall with: npm install rivetkit@pr-4669All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-591a8c9
docker pull rivetdev/engine:full-591a8c9Individual packagesnpm install rivetkit@pr-4669
npm install @rivetkit/react@pr-4669
npm install @rivetkit/rivetkit-native@pr-4669
npm install @rivetkit/sqlite-wasm@pr-4669
npm install @rivetkit/workflow-engine@pr-4669 |
PR Review:
|
| Priority | Location | Issue |
|---|---|---|
| Critical | runtime-router/router.ts |
Add missing import { readDevtoolsBundle } |
| High | runtime-router/router.ts |
Gate /devtools/mod.js inside if (config.inspector.enabled) |
| High | scripts/run/dev-env.sh |
Add RIVET__GUARD__PORT=6423 |
| Medium | devtools-loader/index.ts |
Guard against undefined config.endpoint before template literal |
| Low | drivers/engine/actor-driver.ts |
Add comment or remove explicit notGlobal: false |
986ef51 to
5a4e315
Compare
5a4e315 to
d5a6b40
Compare
d5a6b40 to
b5b770f
Compare
27c5231 to
f6d3128
Compare
Merge activity
|

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: