refactor: inspector tabs bundled with actor#4670
refactor: inspector tabs bundled with actor#4670jog1t wants to merge 1 commit into04-15-refactor_rivetkit_move_devtools_to_local_scriptfrom
Conversation
|
🚅 Deployed to the rivet-pr-4670 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Review: refactor: inspector tabs bundled with actorThis PR introduces a postMessage-based iframe architecture for inspector tabs, where each tab (workflow, database, state, queue, connections, metadata) is built as a separate Vite bundle and rendered inside a sandboxed iframe. The shell communicates with iframes via a structured message protocol to bridge the inspector API and sync query cache. This is a well-thought-out architectural change. Bugs / CorrectnessDead code: The
In
In
SecurityCSP In Per CLAUDE.md the dashboard is at Action dispatch via dynamic key access In Code Quality
The Inline comment about console is slightly imprecise The comment says "console stays inline: ActorWorkerContextProvider uses TanStack Router context unavailable in iframes" -- the actual dependency is SummaryThe core architecture is solid: structured message protocol with origin allowlisting, query cache hydration via BroadcastChannel, iframe lifecycle deferred to first tab activation, and an explicit action allowlist at the bridge boundary. Main actionable items:
|
1fe66d4 to
a190d13
Compare
986ef51 to
5a4e315
Compare
a190d13 to
f7625ea
Compare
5a4e315 to
d5a6b40
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: