fix(frontend): drive VITE_APP_SENTRY_ENV from DEPLOYMENT_TYPE#4678
fix(frontend): drive VITE_APP_SENTRY_ENV from DEPLOYMENT_TYPE#4678
Conversation
RAILWAY_ENVIRONMENT_NAME was not declared as ARG in the Dockerfiles, so it was never available at build time and VITE_APP_SENTRY_ENV always baked in 'staging' regardless of the target environment.
|
🚅 Deployed to the rivet-pr-4678 environment in rivet-frontend
|
Code ReviewOverviewThis PR fixes a build-time bug where AnalysisCorrectness: The fix is correct. Both Dockerfiles declare Consistency: The No regressions: Removing the undeclared, platform-specific Suggestions
VerdictSmall, correct, low-risk bugfix. Approve. |
Preview packages published to npmInstall with: npm install rivetkit@pr-4678All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-a4d58ee
docker pull rivetdev/engine:full-a4d58eeIndividual packagesnpm install rivetkit@pr-4678
npm install @rivetkit/react@pr-4678
npm install @rivetkit/rivetkit-native@pr-4678
npm install @rivetkit/sqlite-wasm@pr-4678
npm install @rivetkit/workflow-engine@pr-4678 |
RAILWAY_ENVIRONMENT_NAME was not declared as ARG in the Dockerfiles, so
it was never available at build time and VITE_APP_SENTRY_ENV always
baked in 'staging' regardless of the target environment.