chore(rivetkit): remove legacy metrics

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(rivetkit-core): gate startup until runtime is ready #4736 : 2 dependent PRs (#4737 , #4739 )
• fix(rivetkit-sqlite): preserve text with embedded nul bytes #4735
• chore(rivetkit): add child spans for logging #4734
• fix(rivetkit-core): orphan engine process and detect crashes #4733
• fix(rivetkit-core): return None for empty inspector state to avoid frontend CBOR decode error #4732
• fix(rivetkit-core): don't install tokio::signal::ctrl_c() handler inside serve_with_config #4731
• refactor(rivetkit-core): use subtle::ConstantTimeEq for inspector token verify #4730
• fix(rivetkit): drop is_read_only_sql classifier, surface RETURNING rows #4728
• docs: require close-code rejection for websocket auth/policy failures #4727
• fix(rivetkit): inspector reports actual config state + real queue messages #4726
• fix(rivetkit-napi): plumb ctx through serializeState TSF and stop panicking on runtime_state Ref drop #4725
• chore(rivetkit): remove legacy metrics & prometheus auth #4724
• chore(rivetkit): remove legacy metrics #4723 👈 (View in Graphite)
• chore(rivetkit): impl inspector token #4722
• chore: disable auth on serverless #4721
• chore: fix cors for envoys #4720
• chore: fix serverless in rivetkit-core #4719
• chore(rivetkit): impl follow up review #4711
• chore: rivetkit core/napi/typescript follow up review #4702
• chore: fix remaining issues with rivetkit-core #4701
• chore: sqlite v1 to v2 data migration #4692 : 1 other dependent PR (#4640 )
• chore: move rivetkit to task model #4680
• chore: rivetkit to rust #4679
• feat(rivetkit): sqlite vfs v2 #4673
• chore: rename sandbox -> kitchen sink #4671 : 1 other dependent PR (#4672 )
• chore: configure TLS trust roots for rustls clients #4667
• fix(rivetkit): update config to match envoys & remove manager references #4663
• chore(publish): pin docker base image refs #4652
• chore(engine): publish engine bases in ci #4649 : 2 other dependent PRs (#4650 , #4666 )
• chore: lockfile lefthook #4647
• fix(rivetkit): surface native sqlite kv errors to callers #4645
• fix(rivetkit): prevent sleep races during disconnect and db work #4644
• fix(rivetkit): isolate engine envoys and propagate startup failures #4643
• test(rivetkit): remove wasm sqlite-only fixtures and coverage #4642
• chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring #4641
• chore(rivetkit): remove wasm sqlite runtime #4614
• fix(sqlite-native): restore native startup kv preload #4639
• fix(sqlite-native): delete metadata before chunk range #4638
• fix(sqlite-native): keep truncate cache coherent #4637
• fix(sqlite-vfs): use delete range for truncate cleanup #4636
• fix(sqlite-native): restore kv error hook #4635
• perf(sqlite-native): avoid cloning cached read chunks #4634
• perf(sqlite-native): gate kv operation labels #4633
• perf(sqlite-native): reuse read cache for partial writes #4632
• perf(sqlite-native): remove delete file existence probe #4631
• fix(sqlite-native): gate native read cache behind env var #4630
• fix(pegboard): isolate runner config dc lookup failures #4625 : 1 other dependent PR (#4626 )
• docs(pegboard): note runner config upsert split write risk #4624
• fix(pegboard): unpack global runner config keys correctly #4623
• fix(pegboard-gateway): enforce tunnel message state #4622
• fix(pegboard-runner): clear terminal tunnel routes #4621
• fix(pegboard): skip protocol version keys in runner pool backfill #4620
• fix(pegboard): create missing normal runner configs #4619
• fix(epoxy): reuse cached optimistic value #4618
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: chore(rivetkit): remove legacy metrics

Summary

This PR does three largely independent things:

1. Removes the metricsResponse closure and the GET /inspector/metrics HTTP route from native.ts.
2. Adds an actions field to ActorConfig / ActorConfigInput / JsActorConfig, threads it through the NAPI bridge, and uses it to populate inspector_rpcs in rivetkit-core.
3. Renames the test-only inspector token env var from RIVET_INSPECTOR_TOKEN to _RIVET_TEST_INSPECTOR_TOKEN in buildNativeRegistry.
4. Adds three performance.now() debug log timings around createState, createVars, and onWake.

---

Issues

1. Orphaned tests for the deleted /inspector/metrics endpoint (significant)

rivetkit-typescript/packages/rivetkit/tests/driver/actor-inspector.test.ts contains tests that assert on the now-deleted GET /inspector/metrics route. After this PR those tests will receive a 404 and fail. They were not removed or updated.

2. _RIVET_TEST_INSPECTOR_TOKEN rename appears half-complete

buildNativeRegistry in native.ts now sets _RIVET_TEST_INSPECTOR_TOKEN, and the Rust inspector tests at rivetkit-rust/packages/rivetkit-core/tests/modules/inspector.rs already use _RIVET_TEST_INSPECTOR_TOKEN. However rivetkit-rust/packages/rivetkit-core/src/inspector/auth.rs continues to read only RIVET_INSPECTOR_TOKEN. The _RIVET_TEST_INSPECTOR_TOKEN variable set by the TypeScript test harness will never be observed by the Rust auth path, so inspector auth will silently fail in test mode.

3. Dual RPC list computation that can silently diverge

buildActorConfig now builds actions from Object.keys(config.actions).sort() and passes it to Rust for inspector_rpcs. The JS-side /inspector/rpcs HTTP handler in native.ts independently re-derives the list with Object.keys(actionHandlers).sort(). If one is updated without the other, the RPC lists seen by the WebSocket inspector broadcast path (Rust) and the HTTP path (TypeScript) will diverge. Ideally the JS path should delegate to the Rust-side config, or at minimum share a constant.

4. Redundant startup timing logs

The three new performance.now() debug logs in the native path (for createState, createVars, onWake) duplicate logs already emitted by the JS ActorInstance.#measureStartup for the same phases. This produces double entries in log output and may confuse tooling.

5. config.actions cast suppresses future type safety

In buildActorConfig: (config.actions ?? {}) as Record<string, unknown>. The intermediate cast to Record<string, unknown> suppresses any type error if config.actions is ever given a non-object type in the future. A narrower cast or explicit type guard would be safer.

---

Positive observations

• Removing metricsResponse eliminates a large block of hardcoded stub data (startup metrics all returning 0 or 1). The cleanup is welcome.
• Threading actions through ActorConfigInput → ActorConfig → inspector_rpcs is the correct approach per the layer architecture (inspector logic belongs in rivetkit-core).
• The From<JsActorConfig> for ActorConfigInput conversion correctly maps JsActionDefinition → ActionDefinition without leaking NAPI types into core.
• The .sort() in buildActorConfig ensures deterministic ordering, consistent with the existing JS /inspector/rpcs sort.

---

Verdict

The most important issues to address before merging are #1 (orphaned metrics tests will fail CI), #2 (env-var rename appears half-complete and may silently break inspector auth in test mode), and #3 (dual RPC list computation that can silently diverge). Issues #4–#5 are lower severity.

[github-actions]

Preview packages published to npm

Install with:

npm install rivetkit@pr-4723

All packages published as 0.0.0-pr.4723.8dd3380 with tag pr-4723.

Engine binary is shipped via @rivetkit/engine-cli on linux-x64-musl, linux-arm64-musl, darwin-x64, and darwin-arm64. Windows users should use the release installer or set RIVET_ENGINE_BINARY.

Docker images:

docker pull rivetdev/engine:slim-8dd3380
docker pull rivetdev/engine:full-8dd3380

Individual packages

npm install rivetkit@pr-4723
npm install @rivetkit/react@pr-4723
npm install @rivetkit/rivetkit-napi@pr-4723
npm install @rivetkit/workflow-engine@pr-4723

[NathanFlurry]

Landed in main via stack-merge fast-forward push. Commits are in main; closing to match.