fix(rivetkit-napi): plumb ctx through serializeState TSF and stop panicking on runtime_state Ref drop

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(rivetkit-core): gate startup until runtime is ready #4736 : 2 dependent PRs (#4737 , #4739 )
• fix(rivetkit-sqlite): preserve text with embedded nul bytes #4735
• chore(rivetkit): add child spans for logging #4734
• fix(rivetkit-core): orphan engine process and detect crashes #4733
• fix(rivetkit-core): return None for empty inspector state to avoid frontend CBOR decode error #4732
• fix(rivetkit-core): don't install tokio::signal::ctrl_c() handler inside serve_with_config #4731
• refactor(rivetkit-core): use subtle::ConstantTimeEq for inspector token verify #4730
• fix(rivetkit): drop is_read_only_sql classifier, surface RETURNING rows #4728
• docs: require close-code rejection for websocket auth/policy failures #4727
• fix(rivetkit): inspector reports actual config state + real queue messages #4726
• fix(rivetkit-napi): plumb ctx through serializeState TSF and stop panicking on runtime_state Ref drop #4725 👈 (View in Graphite)
• chore(rivetkit): remove legacy metrics & prometheus auth #4724
• chore(rivetkit): remove legacy metrics #4723
• chore(rivetkit): impl inspector token #4722
• chore: disable auth on serverless #4721
• chore: fix cors for envoys #4720
• chore: fix serverless in rivetkit-core #4719
• chore(rivetkit): impl follow up review #4711
• chore: rivetkit core/napi/typescript follow up review #4702
• chore: fix remaining issues with rivetkit-core #4701
• chore: sqlite v1 to v2 data migration #4692 : 1 other dependent PR (#4640 )
• chore: move rivetkit to task model #4680
• chore: rivetkit to rust #4679
• feat(rivetkit): sqlite vfs v2 #4673
• chore: rename sandbox -> kitchen sink #4671 : 1 other dependent PR (#4672 )
• chore: configure TLS trust roots for rustls clients #4667
• fix(rivetkit): update config to match envoys & remove manager references #4663
• chore(publish): pin docker base image refs #4652
• chore(engine): publish engine bases in ci #4649 : 2 other dependent PRs (#4650 , #4666 )
• chore: lockfile lefthook #4647
• fix(rivetkit): surface native sqlite kv errors to callers #4645
• fix(rivetkit): prevent sleep races during disconnect and db work #4644
• fix(rivetkit): isolate engine envoys and propagate startup failures #4643
• test(rivetkit): remove wasm sqlite-only fixtures and coverage #4642
• chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring #4641
• chore(rivetkit): remove wasm sqlite runtime #4614
• fix(sqlite-native): restore native startup kv preload #4639
• fix(sqlite-native): delete metadata before chunk range #4638
• fix(sqlite-native): keep truncate cache coherent #4637
• fix(sqlite-vfs): use delete range for truncate cleanup #4636
• fix(sqlite-native): restore kv error hook #4635
• perf(sqlite-native): avoid cloning cached read chunks #4634
• perf(sqlite-native): gate kv operation labels #4633
• perf(sqlite-native): reuse read cache for partial writes #4632
• perf(sqlite-native): remove delete file existence probe #4631
• fix(sqlite-native): gate native read cache behind env var #4630
• fix(pegboard): isolate runner config dc lookup failures #4625 : 1 other dependent PR (#4626 )
• docs(pegboard): note runner config upsert split write risk #4624
• fix(pegboard): unpack global runner config keys correctly #4623
• fix(pegboard-gateway): enforce tunnel message state #4622
• fix(pegboard-runner): clear terminal tunnel routes #4621
• fix(pegboard): skip protocol version keys in runner pool backfill #4620
• fix(pegboard): create missing normal runner configs #4619
• fix(epoxy): reuse cached optimistic value #4618
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review

PR: fix(rivetkit-napi): plumb ctx through serializeState TSF and stop panicking on runtime_state Ref drop
Status: Draft

Overview

This PR makes four targeted fixes in the NAPI bridge:

1. Stops a debug-mode panic (and silent release-mode leak) when dropping a Ref<()> without an Env on a tokio worker thread.
2. Adds a Drop impl on ActorContextShared with the same guard.
3. Fixes the reason field in build_serialize_state_payload to use env.create_string_from_std instead of a raw String push.
4. Removes the redundant name field from build_action_payload (the callback is already keyed by name at registration).
5. Adds has_database propagation from buildActorConfig in TypeScript through to the NAPI JsActorConfig.
6. Narrows SerializeStateReason in TypeScript to match the Rust enum ("save" | "inspector" only).

---

Critical Issue

has_database is added to From<JsActorConfig> for ActorConfigInput but ActorConfigInput in rivetkit-core does not have this field.

rivetkit-rust/packages/rivetkit-core/src/actor/config.rs — ActorConfigInput struct has no has_database field on either the base branch or the head branch of this PR. The From impl will fail to compile:

// actor_factory.rs — From<JsActorConfig> for ActorConfigInput
Self {
    name: value.name,
    icon: value.icon,
    has_database: value.has_database,  // ERROR: no field `has_database` on ActorConfigInput
    ...
}

Resolution options:

• Add pub has_database: Option<bool> to ActorConfigInput and wire it through ActorConfig::from_input in rivetkit-core (likely the right path if the core needs to know about the database).
• If has_database is only needed at the NAPI layer to decide whether to open SQLite, strip the field from the From<JsActorConfig> for ActorConfigInput conversion and keep it only in JsActorConfig.

---

mem::forget for Ref<()> (Medium)

The fix in reset_runtime_state and the new Drop impl is a pragmatic stopgap. The comment accurately describes the tradeoff: avoids a debug assert panic, but leaks one napi reference slot per actor wake cycle for the process lifetime.

if let Some(old) = self.runtime_state.lock().take() {
    std::mem::forget(old);  // intentional bounded leak
}

This is acceptable as a short-term fix, but a proper solution would schedule Ref::unref(env) back onto the Node.js event loop thread (e.g. via a ThreadsafeFunction with no payload, or a napi::Env-capturing closure queued through libuv). A follow-up task in .agent/todo/ or a TODO comment pointing to a tracking issue would be useful here so this isn't forgotten.

---

Correct Fixes

• env.create_string_from_std(payload.reason) — using the explicit napi constructor instead of relying on blanket ToNapiValue for String is the right call for clarity and reliability.
• Removing name from build_action_payload — actions are registered per-name, so the name is redundant in the JS-side payload. The field remains in ActionPayload and is used by TsfnPayloadSummary for logging, which is fine.
• SerializeStateReason narrowing — aligns the TypeScript type alias with the Rust SerializeStateReason enum (Save/Inspector only). Correct.
• hasDatabase: config.db !== undefined — clean detection of whether an SQLite database is configured; the boolean is derived from presence rather than re-checking at call time.

---

Minor

• ActionPayload.name stays in the struct (consumed by TsfnPayloadSummary for logging) but is no longer forwarded to JS. No cleanup needed now, but worth noting in case the field becomes dead weight later.

---

Summary

The mem::forget approach and the other targeted fixes are sound. The blocking issue is that ActorConfigInput needs has_database added (or the field removed from the From conversion) before this will compile. Everything else looks correct and well-scoped.

[NathanFlurry]

Landed in main via stack-merge fast-forward push. Commits are in main; closing to match.