fix(api-public): remove orphan import_export actors module#4764
fix(api-public): remove orphan import_export actors module#4764NathanFlurry wants to merge 1 commit intomainfrom
Conversation
The actors/import_export.rs file was added in 34422ea but its dependencies (rivet-envoy-protocol, serde_bare, rivet-api-types import_export module, pegboard::actor_sqlite_v2, pub visibility of list_inner) were never ported from the unmerged import/export-actors branch. Result: rivet-api-public fails to compile on main, breaking all engine Docker builds and Rust CI. Drop the file and its mod.rs/router.rs wiring until the supporting pieces land.
|
🚅 Deployed to the rivet-pr-4764 environment in rivet-frontend
|
Code ReviewOverviewThis is a targeted hotfix that removes an orphaned 874-line file ( Assessment: Approve with one noteThe change is correct, minimal, and the right call. Attempting to patch in the missing pieces in-place would be riskier than clean removal and re-introduction in a self-contained PR. ObservationsThe Lingering references in engine tests. The PR description states "no other code references these symbols," but two test files in
Those test files live in dev-dependencies of Removed test coverage is acceptable here. The four unit tests inside the deleted file ( The deleted code quality was solid. The batch pagination loop, rollback-on-failure path, deduplication logic, and Suggestions for the follow-up import/export PR
|
Preview packages published to npmInstall with: npm install rivetkit@pr-4764All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-4370035
docker pull rivetdev/engine:full-4370035Individual packagesnpm install rivetkit@pr-4764
npm install @rivetkit/react@pr-4764
npm install @rivetkit/rivetkit-napi@pr-4764
npm install @rivetkit/workflow-engine@pr-4764 |

Summary
mainis currently broken on Rust CI and all engine Docker builds. Commit 34422ea93 ("chore: fix remaining issues with rivetkit-core") addedengine/packages/api-public/src/actors/import_export.rs(874 lines, lifted from the unmerged04-12-feat_import_export_actorsbranch) and wired it intomod.rs+router.rs, but the supporting pieces it depends on were never ported:rivet-envoy-protocolandserde_baredeps inengine/packages/api-public/Cargo.tomlimport_export/import_createmodules inrivet-api-types::actorsactor_sqlite_v2module inpegboardpubvisibility onlist_innerrivet-api-publicfails with 15 compile errors (E0432 / E0433 / E0603),cargo build --bin rivet-engineexits 101, and everyDocker -arm64 / -amd64 Build & Pushjob on branches offmainfails. Example: https://github.com/rivet-dev/rivet/actions/runs/24889658855/job/72879003373.Test plan
cargo check -p rivet-api-publicpassescargo check --bin rivet-enginepasses