test(rivetkit-core): move private tests to crate root#4792
Conversation
PR #4792 Review: Move private tests to crate rootOverviewMigrates test modules from inline This directly implements the CLAUDE.md requirement: "Rust tests live under What's Good
Issues1. The setting is non-obvious. A future contributor adding a standalone integration test would be surprised it is silently ignored. A comment prevents this: # Tests in tests/ are included via #[path] shims in source files for private-item access.
# They are not standalone integration test binaries, so autotests must stay false.
autotests = false2. CLAUDE.md says test-only global serialization should use #[cfg(test)] use parking_lot::Mutex;
#[cfg(test)] use std::sync::OnceLock;
#[cfg(test)]
pub(crate) fn test_inspector_env_lock() -> &'static Mutex<()> {
static LOCK: OnceLock<Mutex<()>> = OnceLock::new();
LOCK.get_or_init(|| Mutex::new(()))
}3. Some files wrap tests in 4. Substantive test fix bundled into a mechanical refactor (low risk, worth noting) The SummaryThe approach is sound and the CLAUDE.md requirement is satisfied. The two actionable items are the missing |
Preview packages published to npmInstall with: npm install rivetkit@pr-4792All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-8c20f1a
docker pull rivetdev/engine:full-8c20f1aIndividual packagesnpm install rivetkit@pr-4792
npm install @rivetkit/react@pr-4792
npm install @rivetkit/rivetkit-napi@pr-4792
npm install @rivetkit/workflow-engine@pr-4792 |
e113941 to
448a22d
Compare
55071a7 to
2408188
Compare
448a22d to
f691ba2
Compare
0b216fc to
d66a0b9
Compare
2ba33ef to
da8c2af
Compare
d66a0b9 to
5b530d1
Compare
da8c2af to
6fdd701
Compare
5b530d1 to
d4ab11d
Compare
6fdd701 to
c23eb1d
Compare
d4ab11d to
e975b91
Compare
c23eb1d to
81d507e
Compare
e975b91 to
9648497
Compare
81d507e to
752dc10
Compare
752dc10 to
3acdfe8
Compare
0939a5c to
4514b8b
Compare
3acdfe8 to
3cb32e3
Compare
4514b8b to
1527048
Compare
3cb32e3 to
0a6cfad
Compare
0a6cfad to
f19a1d1
Compare
1527048 to
aec3641
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: