fix(envoy-protocol): advertise current protocol version

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(pegboard): stabilize actor2 validation and lifecycle #4804 : 2 dependent PRs (#4805 , #4808 )
• fix(pegboard): decode envoy actor eviction keys #4803
• fix(pegboard-envoy): subscribe before registering envoy #4802
• fix(envoy-client): clear processed_command_idx after ack send #4812
• fix(envoy-client): dedupe replayed commands by index #4811
• fix(envoy-client): complete command and request lifecycles #4801
• fix(envoy-protocol): advertise current protocol version #4800 👈 (View in Graphite)
• fix(guard): serialize gateway actor keys correctly #4655
• fix(rivetkit-native): expose full hibernation metadata to JS #4657
• chore(rivetkit): remove inline tests #4668
• fix(api): subscribe before namespace workflow dispatch #4654
• fix(rivetkit): restore hibernatable sockets and hydrate serverless starts #4658
• fix(pegboard): persist and replay hibernating requests #4656
• fix(rivetkit): keep internal error exposure behavior consistent #4661
• test(rivetkit): stabilize actor db driver tests #4664
• fix(test): stabilize lifecycle, sleep, queue, and run edge cases #4660 : 1 other dependent PR (#4665 )
• test(rivetkit): re-enable gateway URL and direct-registry coverage #4659
• fix(rivetkit): add lifecycle error retry and gateway HTTP routing #4666
• fix(rivetkit-core): remove legacy timeouts #4799
• docs: add replay guidance notes #4796
• fix(inspector): stream patched state updates #4795
• fix(rivetkit): refresh stale actor handles #4794
• test(rivetkit-napi): move private tests to crate root #4793
• test(rivetkit-core): move private tests to crate root #4792
• test(runner-configs): assert envoy protocol version #4791
• fix(serverless): split metadata protocol errors #4789 : 1 other dependent PR (#4790 )
• chore(sqlite): add open close lifecycle for envoy actors #4788
• fix(rivetkit): share lifecycle shutdown grace #4810
• fix(pegboard): move sqlite v1 migration into actor workflow #4787 : 1 other dependent PR (#4797 )
• test(rivetkit): cover c.db access from onWake/onSleep/onDestroy #4786
• fix(rivetkit-napi): run onMigrate before createState/onCreate/createVars #4785
• refactor(rivetkit-core): merge ready+started into lifecycle_started, drop redundant napi calls #4784
• fix(rivetkit): drain native sleep side tasks reliably #4782 : 1 other dependent PR (#4783 )
• fix(rivetkit): route raw request fetches to actors #4781
• fix(pegboard): refresh runner config after envoy connect #4778 : 2 other dependent PRs (#4779 , #4798 )
• chore(kitchen-sink): configurable endpoint #4766 : 2 other dependent PRs (#4754 , #4777 )
• refactor(rivetkit-core): rename StopReason to ShutdownKind and kill enum fallthroughs #4765
• chore(envoy-client): log command and event payloads #4751
• fix(rivetkit): minor sleep-cleanup follow-ups #4761
• docs(rivetkit): clean up stale setPreventSleep references in docs and JSDoc #4760
• docs(rivetkit): document keepAwake/waitUntil counter-arm race and surface bridge errors #4759
• test(engine): force overdue branch in alarm-during-sleep test with negative offset #4758
• fix(rivetkit-core): return stopping not starting when sleep/destroy called mid-shutdown #4757
• test(rivetkit): remove sleepWithPreventSleep fixture and tests #4756
• test(engine): add regression test for alarm-during-sleep-transition race #4755
• test(rivetkit-core): cover sleep/destroy guards and prevent_sleep no-op #4750
• docs: add keepAwake vs waitUntil table and internal sleep-sequence invariants #4749
• feat(rivetkit): expose c.keepAwake(promise) through native path #4748
• refactor(rivetkit): deprecate setPreventSleep to no-op in TypeScript #4747
• fix(rivetkit-core): enumerate non-drained counters in grace deadline warn log #4746
• fix(rivetkit-core): abort graceful cleanup task when grace deadline elapses #4745
• fix(rivetkit-core): error on sleep/destroy before startup or already-requested #4743
• fix(rivetkit-core): cap SerializeState shutdown timeout at 15s #4742
• refactor(rivetkit-core): remove prevent_sleep field and deprecate set_prevent_sleep to no-op #4741
• fix(api-public): remove orphan import_export actors module #4764
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR #4800 Review: fix(envoy-protocol): advertise current protocol version

Note: This is a DRAFT PR — feedback is provided for early visibility.

Overview

This PR fixes a bug where the deserialize_converters() and serialize_converters() methods on all six versioned envoy-protocol message types (ToEnvoy, ToRivet, ToGateway, ToOutbound, ToEnvoyConn, ActorCommandKeyData) returned only one identity converter (vec![Ok]) when the protocol actually has three schema versions (v1, v2, v3).

The vbare::OwnedVersionedData trait uses converters.len() + 1 to determine the current/latest protocol version. With vec![Ok] (length 1), vbare advertised version 2; with vec![Ok, Ok] (length 2), it correctly advertises version 3, aligning with PROTOCOL_VERSION: u16 = 3 in lib.rs.

---

Correctness

The fix is correct. The invariant is confirmed by other impls in the codebase:

Type	Versions	Converter count	Version constant
RunnerAllocIdxKeyData	V1, V2	1	PEGBOARD_NAMESPACE_RUNNER_ALLOC_IDX_VERSION = 2
NamespaceRunnerConfig	V1-V5	4	PEGBOARD_NAMESPACE_RUNNER_CONFIG_VERSION = 5
ToEnvoy (before PR)	V1, V2, V3	1 (wrong)	PROTOCOL_VERSION = 3
ToEnvoy (after PR)	V1, V2, V3	2 (correct)	PROTOCOL_VERSION = 3

All six message types are updated consistently. Identity converters (Ok) are appropriate here because the actual per-version migration logic already lives in deserialize_version() / serialize_version().

---

Suggestions

• Test coverage: There is no test asserting that the advertised embedded version matches PROTOCOL_VERSION. A simple round-trip test that calls serialize_with_embedded_version(PROTOCOL_VERSION), reads back the embedded version bytes, and asserts equality to PROTOCOL_VERSION would catch this class of regression for all six types.

• PR description: The description is still template boilerplate. Filling in the motivation (what observable behavior was broken by the mismatch?) would help reviewers and future readers understand the impact.

• Identity converter intent: Using Ok as a converter is non-obvious. A short inline comment explaining that the length controls the advertised version number, and Ok is used because the actual cross-version logic is already in serialize_version / deserialize_version, would help future maintainers when adding v4.

---

No concerns on

• Style and formatting match the surrounding file.
• No public API surface changes.
• No security or performance impact.
• The change is minimal and scoped precisely to the bug.

Generated with Claude Code