fix(pegboard): stabilize actor2 validation and lifecycle

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(pegboard): stabilize actor2 validation and lifecycle #4804 : 2 dependent PRs (#4805 , #4808 ) 👈 (View in Graphite)
• fix(pegboard): decode envoy actor eviction keys #4803
• fix(pegboard-envoy): subscribe before registering envoy #4802
• fix(envoy-client): clear processed_command_idx after ack send #4812
• fix(envoy-client): dedupe replayed commands by index #4811
• fix(envoy-client): complete command and request lifecycles #4801
• fix(envoy-protocol): advertise current protocol version #4800
• fix(guard): serialize gateway actor keys correctly #4655
• fix(rivetkit-native): expose full hibernation metadata to JS #4657
• chore(rivetkit): remove inline tests #4668
• fix(api): subscribe before namespace workflow dispatch #4654
• fix(rivetkit): restore hibernatable sockets and hydrate serverless starts #4658
• fix(pegboard): persist and replay hibernating requests #4656
• fix(rivetkit): keep internal error exposure behavior consistent #4661
• test(rivetkit): stabilize actor db driver tests #4664
• fix(test): stabilize lifecycle, sleep, queue, and run edge cases #4660 : 1 other dependent PR (#4665 )
• test(rivetkit): re-enable gateway URL and direct-registry coverage #4659
• fix(rivetkit): add lifecycle error retry and gateway HTTP routing #4666
• fix(rivetkit-core): remove legacy timeouts #4799
• docs: add replay guidance notes #4796
• fix(inspector): stream patched state updates #4795
• fix(rivetkit): refresh stale actor handles #4794
• test(rivetkit-napi): move private tests to crate root #4793
• test(rivetkit-core): move private tests to crate root #4792
• test(runner-configs): assert envoy protocol version #4791
• fix(serverless): split metadata protocol errors #4789 : 1 other dependent PR (#4790 )
• chore(sqlite): add open close lifecycle for envoy actors #4788
• fix(rivetkit): share lifecycle shutdown grace #4810
• fix(pegboard): move sqlite v1 migration into actor workflow #4787 : 1 other dependent PR (#4797 )
• test(rivetkit): cover c.db access from onWake/onSleep/onDestroy #4786
• fix(rivetkit-napi): run onMigrate before createState/onCreate/createVars #4785
• refactor(rivetkit-core): merge ready+started into lifecycle_started, drop redundant napi calls #4784
• fix(rivetkit): drain native sleep side tasks reliably #4782 : 1 other dependent PR (#4783 )
• fix(rivetkit): route raw request fetches to actors #4781
• fix(pegboard): refresh runner config after envoy connect #4778 : 2 other dependent PRs (#4779 , #4798 )
• chore(kitchen-sink): configurable endpoint #4766 : 2 other dependent PRs (#4754 , #4777 )
• refactor(rivetkit-core): rename StopReason to ShutdownKind and kill enum fallthroughs #4765
• chore(envoy-client): log command and event payloads #4751
• fix(rivetkit): minor sleep-cleanup follow-ups #4761
• docs(rivetkit): clean up stale setPreventSleep references in docs and JSDoc #4760
• docs(rivetkit): document keepAwake/waitUntil counter-arm race and surface bridge errors #4759
• test(engine): force overdue branch in alarm-during-sleep test with negative offset #4758
• fix(rivetkit-core): return stopping not starting when sleep/destroy called mid-shutdown #4757
• test(rivetkit): remove sleepWithPreventSleep fixture and tests #4756
• test(engine): add regression test for alarm-during-sleep-transition race #4755
• test(rivetkit-core): cover sleep/destroy guards and prevent_sleep no-op #4750
• docs: add keepAwake vs waitUntil table and internal sleep-sequence invariants #4749
• feat(rivetkit): expose c.keepAwake(promise) through native path #4748
• refactor(rivetkit): deprecate setPreventSleep to no-op in TypeScript #4747
• fix(rivetkit-core): enumerate non-drained counters in grace deadline warn log #4746
• fix(rivetkit-core): abort graceful cleanup task when grace deadline elapses #4745
• fix(rivetkit-core): error on sleep/destroy before startup or already-requested #4743
• fix(rivetkit-core): cap SerializeState shutdown timeout at 15s #4742
• refactor(rivetkit-core): remove prevent_sleep field and deprecate set_prevent_sleep to no-op #4741
• fix(api-public): remove orphan import_export actors module #4764
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: fix(pegboard): stabilize actor2 validation and lifecycle

Overview

This PR makes three categories of fixes to the actor2 workflow:

1. Validation gating — adds an upfront Validate activity before state is written, so invalid actors fail fast and cleanly
2. crash_policy propagation — fixes a hardcoded CrashPolicy::Sleep bug and wires the actual policy through the actor2 lifecycle
3. Transition correctness — aligns handle_stopped allocation transitions with the initial-allocation path (Serverful → Starting, Serverless → Allocating) and resets stale sleep_ts/reschedule_ts on reallocation

---

Correctness

crash_policy propagation is a clear bug fix. build_actors_from_workflows was silently ignoring the stored policy and forcing Sleep — now it reads from state. Good.

Transition fix for Serverful (runtime.rs:624–642, 671–688): The new match block mirrors the pattern already used in the initial allocation path (runtime.rs:463–480). Setting state.transition before start_new_generation is also consistent with how the initial path does it. Both changes look correct.

sleep_ts / reschedule_ts reset in allocate (runtime.rs:301–302): Clearing these on reallocation is correct — stale timestamps from a previous generation would otherwise bleed into the new one.

Validation before InitStateAndUdbInput (mod.rs:121–148): Gating the entire workflow on a validation activity prevents half-initialized state from landing in UDB. This is the right architectural move.

---

Issues

Unused name field in ValidateInput (mod.rs:256–260): name is present in the struct but never read inside validate(). Since it's identical to the v1 setup at actor/setup.rs:12–16, it may be intended for future format/length checks. It currently produces dead-field noise and the compiler will warn. Either add the validation or remove the field until it's needed.

Code duplication: The entire validate function body (mod.rs:265–303) is a verbatim copy of actor/setup.rs:20–54, including the ValidateInput struct and MAX_INPUT_SIZE constant. These should live in a shared module (e.g., ops/actor/ or workflows/actor/shared.rs) to avoid the two implementations drifting.

Dead constants (mod.rs:19–20): SQLITE_SCHEMA_VERSION_V1 and SQLITE_SCHEMA_VERSION_V2 are declared pub const but have no usages anywhere in the codebase. If they're placeholder scaffolding for an upcoming migration, a comment explaining their purpose would help; otherwise remove them.

Magic number in key validation (mod.rs:291–296): The limit 1024 appears twice inline. Extract it as const MAX_KEY_SIZE: usize = 1024; alongside MAX_INPUT_SIZE for consistency.

---

Migration / backward compatibility

#[serde(default)] on State.crash_policy (mod.rs:43–44): Existing persisted actor2 workflows that pre-date this field will deserialize with CrashPolicy::Destroy (the #[default] variant). Previously, build_actors_from_workflows was returning CrashPolicy::Sleep for those actors. The behavioral change — from sleep-on-crash to destroy-on-crash for in-flight actors that don't have the field yet — should be explicitly confirmed as intentional, since it affects live actors surviving a rolling deploy.

---

Summary

The core fixes (crash_policy propagation, stale-timestamp reset, Serverful transition, validation gating) are all correct and well-targeted. The main things to address before merging: the duplicated validation code, the unused name field, the dead SQLITE_SCHEMA_VERSION constants, and explicit confirmation that the serde default for crash_policy is the desired migration behavior.