fix(gasoline): skip malformed active worker indexes#4806
Closed
NathanFlurry wants to merge 1 commit intoengine-stabilize/sqlite-v1-migration-openfrom
Closed
fix(gasoline): skip malformed active worker indexes#4806NathanFlurry wants to merge 1 commit intoengine-stabilize/sqlite-v1-migration-openfrom
NathanFlurry wants to merge 1 commit intoengine-stabilize/sqlite-v1-migration-openfrom
Conversation
This was referenced Apr 27, 2026
Member
Author
This was referenced Apr 27, 2026
PR Review: fix(gasoline): skip malformed active worker indexesVerdict: Looks good — small, focused resilience fix. What the change doesWhen iterating active worker index keys from FDB, a malformed key previously propagated as an error and terminated the entire scan. The fix wraps the unpack in a Code quality
Potential issuesNone. The change is appropriate for handling mixed-version deploys or rare KV corruption where an old or partial index entry cannot be decoded. Test coverageNo new tests. Writing a unit test would require injecting raw malformed FDB keys into the harness, which is non-trivial. Given the small scope and consistency with already-untested sibling paths, this is acceptable. SummaryClean defensive change that matches established codebase conventions. No concerns. |
1fbd8c3 to
f29750e
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: