fix(api-peer): refresh runner config list reads

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(api-peer): refresh runner config list reads #4807 👈 (View in Graphite)
• fix(gasoline): skip malformed active worker indexes #4806
• fix(sqlite-storage): open v1 migration stages #4805
• fix(pegboard): stabilize actor2 validation and lifecycle #4804 : 1 other dependent PR (#4808 )
• fix(pegboard): decode envoy actor eviction keys #4803
• fix(pegboard-envoy): subscribe before registering envoy #4802
• fix(envoy-client): clear processed_command_idx after ack send #4812
• fix(envoy-client): dedupe replayed commands by index #4811
• fix(envoy-client): complete command and request lifecycles #4801
• fix(envoy-protocol): advertise current protocol version #4800
• fix(guard): serialize gateway actor keys correctly #4655
• fix(rivetkit-native): expose full hibernation metadata to JS #4657
• chore(rivetkit): remove inline tests #4668
• fix(api): subscribe before namespace workflow dispatch #4654
• fix(rivetkit): restore hibernatable sockets and hydrate serverless starts #4658
• fix(pegboard): persist and replay hibernating requests #4656
• fix(rivetkit): keep internal error exposure behavior consistent #4661
• test(rivetkit): stabilize actor db driver tests #4664
• fix(test): stabilize lifecycle, sleep, queue, and run edge cases #4660 : 1 other dependent PR (#4665 )
• test(rivetkit): re-enable gateway URL and direct-registry coverage #4659
• fix(rivetkit): add lifecycle error retry and gateway HTTP routing #4666
• fix(rivetkit-core): remove legacy timeouts #4799
• docs: add replay guidance notes #4796
• fix(inspector): stream patched state updates #4795
• fix(rivetkit): refresh stale actor handles #4794
• test(rivetkit-napi): move private tests to crate root #4793
• test(rivetkit-core): move private tests to crate root #4792
• test(runner-configs): assert envoy protocol version #4791
• fix(serverless): split metadata protocol errors #4789 : 1 other dependent PR (#4790 )
• chore(sqlite): add open close lifecycle for envoy actors #4788
• fix(rivetkit): share lifecycle shutdown grace #4810
• fix(pegboard): move sqlite v1 migration into actor workflow #4787 : 1 other dependent PR (#4797 )
• test(rivetkit): cover c.db access from onWake/onSleep/onDestroy #4786
• fix(rivetkit-napi): run onMigrate before createState/onCreate/createVars #4785
• refactor(rivetkit-core): merge ready+started into lifecycle_started, drop redundant napi calls #4784
• fix(rivetkit): drain native sleep side tasks reliably #4782 : 1 other dependent PR (#4783 )
• fix(rivetkit): route raw request fetches to actors #4781
• fix(pegboard): refresh runner config after envoy connect #4778 : 2 other dependent PRs (#4779 , #4798 )
• chore(kitchen-sink): configurable endpoint #4766 : 2 other dependent PRs (#4754 , #4777 )
• refactor(rivetkit-core): rename StopReason to ShutdownKind and kill enum fallthroughs #4765
• chore(envoy-client): log command and event payloads #4751
• fix(rivetkit): minor sleep-cleanup follow-ups #4761
• docs(rivetkit): clean up stale setPreventSleep references in docs and JSDoc #4760
• docs(rivetkit): document keepAwake/waitUntil counter-arm race and surface bridge errors #4759
• test(engine): force overdue branch in alarm-during-sleep test with negative offset #4758
• fix(rivetkit-core): return stopping not starting when sleep/destroy called mid-shutdown #4757
• test(rivetkit): remove sleepWithPreventSleep fixture and tests #4756
• test(engine): add regression test for alarm-during-sleep-transition race #4755
• test(rivetkit-core): cover sleep/destroy guards and prevent_sleep no-op #4750
• docs: add keepAwake vs waitUntil table and internal sleep-sequence invariants #4749
• feat(rivetkit): expose c.keepAwake(promise) through native path #4748
• refactor(rivetkit): deprecate setPreventSleep to no-op in TypeScript #4747
• fix(rivetkit-core): enumerate non-drained counters in grace deadline warn log #4746
• fix(rivetkit-core): abort graceful cleanup task when grace deadline elapses #4745
• fix(rivetkit-core): error on sleep/destroy before startup or already-requested #4743
• fix(rivetkit-core): cap SerializeState shutdown timeout at 15s #4742
• refactor(rivetkit-core): remove prevent_sleep field and deprecate set_prevent_sleep to no-op #4741
• fix(api-public): remove orphan import_export actors module #4764
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: fix(api-peer): refresh runner config list reads

Summary

This is a minimal one-line fix in engine/packages/api-peer/src/runner_configs.rs. The list endpoint for runner configs previously passed bypass_cache: false to pegboard::ops::runner_config::get::Input, meaning reads went through a 5-second TTL cache. The fix changes this to bypass_cache: true, ensuring the list endpoint always reads directly from the store (UniversalDB) rather than serving potentially stale cached data.

---

What the Change Does

The runner_configs::list handler has two code paths:

1. Named lookup (when runner_name/runner_names query params are provided) — calls pegboard::ops::runner_config::get. This was previously cached with a 5-second TTL; now it bypasses the cache.
2. Paginated list (no specific names provided) — calls pegboard::ops::runner_config::list, which does not use the cache at all. This path is unaffected by the PR.

The fix targets path (1) only.

---

Correctness

The fix is correct and matches the established pattern in the codebase. All other callers that need fresh reads already use bypass_cache: true:

• pegboard/src/ops/runner_config/upsert.rs — fresh read before write.
• pegboard/src/workflows/runner_pool_metadata_poller.rs — reads fresh config to drive metadata polling.
• api-public/src/runner_configs/refresh_metadata.rs — reads fresh config to drive metadata refresh.

The only non-critical callers that tolerate stale data (and correctly use bypass_cache: false) are internal workflow scheduling reads in runner_pool.rs and actor/runtime.rs, where a brief stale view is acceptable for scheduling decisions.

The API list endpoint is a user-facing read operation where freshness is expected. Returning stale data (up to 5 seconds old) after a recent upsert would be a correctness issue, particularly for tools or UIs that poll the list immediately after a configuration change.

---

Code Quality

No concerns. The change is minimal, targeted, and consistent with surrounding codebase conventions.

---

Potential Bugs / Gaps

The fix only applies to the named-lookup path. The paginated list path calls pegboard::ops::runner_config::list, which reads directly from UniversalDB without a cache layer and was already always-fresh. There is no inconsistency introduced — both paths now return fresh data.

---

Performance Considerations

Bypassing the cache increases load on UniversalDB for the named-lookup path. This is the correct tradeoff for a user-facing API endpoint where stale data is worse than the marginal extra latency. The bypass_cache: false path with a 5-second TTL makes sense for high-frequency internal scheduling calls (like runner_pool.rs), not for infrequent API list reads triggered by human operators or CI pipelines.

---

Security

No security concerns. The change does not affect authorization checks, trust boundaries, or data exposure. It only affects caching behavior of an already-authorized read.

---

Test Coverage

The existing tests cover the cache-bypass semantics for refresh_metadata but do not directly cover the list endpoint's named-lookup path. A targeted test asserting that an immediate GET /runner-configs?runner_name=X after PUT /runner-configs/X returns the updated config without a 5-second wait would prevent regression. Minor gap, not a blocker.

---

Verdict

The fix is correct, minimal, and consistent with how bypass_cache: true is used everywhere else that needs authoritative reads. Ready to merge.