fix(sqlite-storage): allow invalidate_v1_migration on non-migrating META

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• test(engine): cover envoy Sleep crash policy wake and recovery paths #4816
• refactor(sqlite-storage): extract DBHead to vbare-versioned protocol crate #4815
• refactor(sqlite-storage): rename SqliteOrigin variants for clarity #4814
• fix(sqlite-storage): allow invalidate_v1_migration on non-migrating META #4813 👈 (View in Graphite)
• test(engine): stabilize runner and envoy suites #4809
• fix(pegboard): reject empty actor kv values #4808
• fix(pegboard): stabilize actor2 validation and lifecycle #4804 : 1 other dependent PR (#4805 )
• fix(pegboard): decode envoy actor eviction keys #4803
• fix(pegboard-envoy): subscribe before registering envoy #4802
• fix(envoy-client): clear processed_command_idx after ack send #4812
• fix(envoy-client): dedupe replayed commands by index #4811
• fix(envoy-client): complete command and request lifecycles #4801
• fix(envoy-protocol): advertise current protocol version #4800
• fix(guard): serialize gateway actor keys correctly #4655
• fix(rivetkit-native): expose full hibernation metadata to JS #4657
• chore(rivetkit): remove inline tests #4668
• fix(api): subscribe before namespace workflow dispatch #4654
• fix(rivetkit): restore hibernatable sockets and hydrate serverless starts #4658
• fix(pegboard): persist and replay hibernating requests #4656
• fix(rivetkit): keep internal error exposure behavior consistent #4661
• test(rivetkit): stabilize actor db driver tests #4664
• fix(test): stabilize lifecycle, sleep, queue, and run edge cases #4660 : 1 other dependent PR (#4665 )
• test(rivetkit): re-enable gateway URL and direct-registry coverage #4659
• fix(rivetkit): add lifecycle error retry and gateway HTTP routing #4666
• fix(rivetkit-core): remove legacy timeouts #4799
• docs: add replay guidance notes #4796
• fix(inspector): stream patched state updates #4795
• fix(rivetkit): refresh stale actor handles #4794
• test(rivetkit-napi): move private tests to crate root #4793
• test(rivetkit-core): move private tests to crate root #4792
• test(runner-configs): assert envoy protocol version #4791
• fix(serverless): split metadata protocol errors #4789 : 1 other dependent PR (#4790 )
• chore(sqlite): add open close lifecycle for envoy actors #4788
• fix(rivetkit): share lifecycle shutdown grace #4810
• fix(pegboard): move sqlite v1 migration into actor workflow #4787 : 1 other dependent PR (#4797 )
• test(rivetkit): cover c.db access from onWake/onSleep/onDestroy #4786
• fix(rivetkit-napi): run onMigrate before createState/onCreate/createVars #4785
• refactor(rivetkit-core): merge ready+started into lifecycle_started, drop redundant napi calls #4784
• fix(rivetkit): drain native sleep side tasks reliably #4782 : 1 other dependent PR (#4783 )
• fix(rivetkit): route raw request fetches to actors #4781
• fix(pegboard): refresh runner config after envoy connect #4778 : 2 other dependent PRs (#4779 , #4798 )
• chore(kitchen-sink): configurable endpoint #4766 : 2 other dependent PRs (#4754 , #4777 )
• refactor(rivetkit-core): rename StopReason to ShutdownKind and kill enum fallthroughs #4765
• chore(envoy-client): log command and event payloads #4751
• fix(rivetkit): minor sleep-cleanup follow-ups #4761
• docs(rivetkit): clean up stale setPreventSleep references in docs and JSDoc #4760
• docs(rivetkit): document keepAwake/waitUntil counter-arm race and surface bridge errors #4759
• test(engine): force overdue branch in alarm-during-sleep test with negative offset #4758
• fix(rivetkit-core): return stopping not starting when sleep/destroy called mid-shutdown #4757
• test(rivetkit): remove sleepWithPreventSleep fixture and tests #4756
• test(engine): add regression test for alarm-during-sleep-transition race #4755
• test(rivetkit-core): cover sleep/destroy guards and prevent_sleep no-op #4750
• docs: add keepAwake vs waitUntil table and internal sleep-sequence invariants #4749
• feat(rivetkit): expose c.keepAwake(promise) through native path #4748
• refactor(rivetkit): deprecate setPreventSleep to no-op in TypeScript #4747
• fix(rivetkit-core): enumerate non-drained counters in grace deadline warn log #4746
• fix(rivetkit-core): abort graceful cleanup task when grace deadline elapses #4745
• fix(rivetkit-core): error on sleep/destroy before startup or already-requested #4743
• fix(rivetkit-core): cap SerializeState shutdown timeout at 15s #4742
• refactor(rivetkit-core): remove prevent_sleep field and deprecate set_prevent_sleep to no-op #4741
• fix(api-public): remove orphan import_export actors module #4764
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review: fix(sqlite-storage): allow invalidate_v1_migration on non-migrating META

Overview

This is a small targeted bug fix in reset_v1_migration. Previously, calling invalidate_v1_migration on an actor that had already passed the v1 migration stage (Native or MigratedFromV1 origin) would return a hard InvalidV1MigrationState error. This change makes that case a no-op (returns Ok(false)) since there is nothing stale to clean up, while preserving the hard error for prepare_v1_migration callers where invoking on an already-migrated actor represents a real bug.

The logic is correct and the fix is well-reasoned.

---

Issues

1. Em dash in comment — style violation

CLAUDE.md states: "Do not use em dashes (—). Use periods to separate sentences instead."

// no-op — there is nothing stale to clean up. For

Should be:

// no-op. There is nothing stale to clean up. For

2. Missing test coverage for the new code path

The fix introduces a meaningful new behavior: calling invalidate_v1_migration on an actor in Native or MigratedFromV1 state should return Ok(false) rather than an error. There is no test for this scenario. Given that the existing test suite already covers prepare_v1_migration thoroughly (see prepare_v1_migration_wipes_actor_rows_and_chunk_subkeys), a paired test like invalidate_v1_migration_on_already_migrated_actor_is_noop would be straightforward to add and would guard against regressions.

3. PR description checklist left blank

None of the checklist items are ticked. Worth marking at minimum: bug fix, self-review, and whether tests were added.

---

Minor observations

• bail! is the right tool here and its explicit import is correct per the no-glob-import rule.
• The else if require_stage_in_progress { return Ok(None) } branch (no META at all + invalidate call) is also a correct no-op and is unchanged by this PR.
• invalidate_v1_migration returning Ok(false) for the new path correctly propagates through .is_some() at the call site.

---

Summary

The fix is logically sound and the diff is minimal. Two concrete asks before merge: fix the em dash in the comment, and add a test for the newly allowed no-op path.