Skip to content

fix(pegboard): use Iterator streaming mode in list_names so limit param is honored #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NathanFlurry wants to merge 1 commit into
base: 04-27-chore_engine-tests_convert_envoy_tests_to_sleep_crash_policy_triage_ignored
Choose a base branch
from
Draft

fix(pegboard): use Iterator streaming mode in list_names so limit param is honored #4829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions engine/packages/engine/tests/envoy/api_actors_list_names.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,13 @@ fn list_all_actor_names_in_namespace() {
}

#[test]
// Broken legacy Pegboard Runner test: full engine sweep timed out in
// `list_names_with_pagination`.
#[ignore = "list_names ignores limit param"]
fn list_names_with_pagination() {
common::run(common::TestOpts::new(1).with_timeout(30), |ctx| async move {
let (namespace, _, _runner) =
common::setup_test_namespace_with_envoy(ctx.leader_dc()).await;
let (namespace, _, _runner) = common::setup_test_namespace_with_envoy_for_names(
ctx.leader_dc(),
(0..9).map(|i| format!("actor-{:02}", i)).collect(),
)
.await;

// Create actors with many different names
for i in 0..9 {
Expand Down Expand Up @@ -404,13 +404,13 @@ fn list_names_alphabetical_sorting() {
// MARK: Edge cases

#[test]
// Broken legacy Pegboard Runner test: full engine sweep timed out in
// `list_names_default_limit_100`.
#[ignore = "list_names default limit not applied (returns 1)"]
fn list_names_default_limit_100() {
common::run(common::TestOpts::new(1).with_timeout(30), |ctx| async move {
let (namespace, _, _runner) =
common::setup_test_namespace_with_envoy(ctx.leader_dc()).await;
let (namespace, _, _runner) = common::setup_test_namespace_with_envoy_for_names(
ctx.leader_dc(),
(0..105).map(|i| format!("actor-{:03}", i)).collect(),
)
.await;

// Create 105 actors with different names to test the default limit of 100
for i in 0..105 {
Expand Down
2 changes: 1 addition & 1 deletion engine/packages/pegboard/src/ops/actor/list_names.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ pub async fn pegboard_actor_list_names(ctx: &OperationCtx, input: &Input) -> Res

tx.get_ranges_keyvalues(
universaldb::RangeOption {
mode: StreamingMode::Exact,
mode: StreamingMode::Iterator,
limit: Some(input.limit),
..(start, end).into()
},
Expand Down
Loading