Skip to content

fix(api-peer): make actors_delete idempotent for already-destroyed actors #4830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanFlurry merged 1 commit into from
May 2, 2026
+2 −3
Merged

fix(api-peer): make actors_delete idempotent for already-destroyed actors #4830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions engine/packages/api-peer/src/actors/delete.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ pub async fn delete(ctx: ApiCtx, path: DeletePath, query: DeleteQuery) -> Result
.next()
.ok_or_else(|| pegboard::errors::Actor::NotFound.build())?;

// Already destroyed
// Already destroyed: succeed idempotently
if actor.destroy_ts.is_some() {
return Err(pegboard::errors::Actor::NotFound.build());
return Ok(DeleteResponse {});
}

// Verify the actor belongs to the specified namespace
Expand Down
1 change: 0 additions & 1 deletion engine/packages/engine/tests/envoy/api_actors_delete.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,6 @@ fn delete_remote_actor_verify_propagation() {
// Broken legacy Pegboard Runner coverage: second delete returns
// `actor.not_found` instead of the idempotent success this test expects.
#[test]
#[ignore = "broken legacy Pegboard Runner test: second delete returns actor.not_found"]
fn delete_already_destroyed_actor() {
common::run(common::TestOpts::new(1).with_timeout(30), |ctx| async move {
let (namespace, _, _runner) =
Expand Down
Loading