Skip to content

DO NOT MERGE: fix(engine-runner): send StopCode.Ok for engine-initiated stops #4861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abcxff wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −0
Open

DO NOT MERGE: fix(engine-runner): send StopCode.Ok for engine-initiated stops #4861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0ac168
fix(engine-runner): send StopCode.Ok for engine-initiated stops
abcxff Apr 30, 2026
8b25a10
chore: add workflow_dispatch to pkg-pr-new
abcxff Apr 30, 2026
4901152
fix(rivetkit): set stopIntentSent = true in #handleCommandStopActor
abcxff May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pkg-pr-new.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
push:
branches:
- main
workflow_dispatch:

jobs:
publish:
Expand Down
8 changes: 8 additions & 0 deletions engine/sdks/typescript/runner/src/mod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ export class Runner {
const actor = this.getActor(actorId, generation);
if (!actor) return;

actor.stopIntentSent = true;
// Keep the actor instance in memory during sleep
this.#sendActorIntent(actorId, actor.generation, "sleep");

Expand Down Expand Up @@ -1189,6 +1190,13 @@ export class Runner {
const actorId = commandWrapper.checkpoint.actorId;
const generation = commandWrapper.checkpoint.generation;

// CommandStopActor is always an engine-authorized graceful stop (sleep or
// destroy). Mark stopIntentSent so #sendActorStateUpdate sends StopCode.Ok
// instead of StopCode.Error. The #handleLost path intentionally omits this
// mark so unresponsive actors still surface as errors.
const actor = this.getActor(actorId, generation);
if (actor) actor.stopIntentSent = true;

await this.forceStopActor(actorId, generation);
}

Expand Down
Loading