Skip to content

wip: kitchen sink agentic loop finish#4949

Merged
NathanFlurry merged 1 commit intomainfrom
05-04-wip_kitchen_sink_agentic_loop_finish
May 5, 2026
Merged

wip: kitchen sink agentic loop finish#4949
NathanFlurry merged 1 commit intomainfrom
05-04-wip_kitchen_sink_agentic_loop_finish

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented May 4, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Preview packages published to npm

Install with:

npm install rivetkit@pr-4949

All packages published as 0.0.0-pr.4949.5f0637c with tag pr-4949.

Engine binary is shipped via @rivetkit/engine-cli on linux-x64-musl, linux-arm64-musl, darwin-x64, and darwin-arm64. Windows users should use the release installer or set RIVET_ENGINE_BINARY.

Docker images:

docker pull rivetdev/engine:slim-5f0637c
docker pull rivetdev/engine:full-5f0637c
Individual packages
npm install rivetkit@pr-4949
npm install @rivetkit/react@pr-4949
npm install @rivetkit/rivetkit-napi@pr-4949
npm install @rivetkit/workflow-engine@pr-4949

@NathanFlurry NathanFlurry force-pushed the 05-04-chore_rivetkit_admission_logic_todos branch from 0b1e417 to da325d9 Compare May 4, 2026 15:36
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 4, 2026

Code Review: kitchen-sink agentic loop finish

Note: This is a draft PR — feedback is provided for early guidance.

Overview

This PR modifies the examples/kitchen-sink dev scripts to:

  1. Hardcode VITE_RIVET_ENDPOINT=http://127.0.0.1:6420 into the dev script.
  2. Add a third concurrent process to dev:serverless that polls until the server is ready.
  3. Introduce a new inline dev:serverless:configure script that polls /api/rivet/metadata for up to 2 minutes before erroring.

Issues

Silent error swallowing (dev:serverless:configure)

The catch {} in the polling loop discards all network errors silently. During development, swallowed errors (e.g., DNS failures, ECONNREFUSED with a mismatched port) make it impossible to diagnose why the poller is not making progress. Recommend at minimum logging the caught error:

} catch (err) { console.log('serverless configuration error: ' + err.message); }

Inline script is unreadable

The entire dev:serverless:configure value is a single minified line. This is hard to read, hard to diff, and hard to maintain. Extract it to scripts/wait-for-serverless.mjs (or similar) and reference it as node scripts/wait-for-serverless.mjs. The repo already uses scripts/ for similar helpers.

Asymmetric VITE_RIVET_ENDPOINT between dev and dev:serverless

The dev script now sets VITE_RIVET_ENDPOINT=http://127.0.0.1:6420, but dev:serverless does not. If the serverless mode also needs Vite to point to a specific endpoint, this is likely an omission. If not, a comment explaining the difference would help.

Hardcoded port 6420

The endpoint http://127.0.0.1:6420 is hardcoded with no comment explaining what service owns this port or why it is fixed. If it is the engine's default, call that out. Consider making it overridable via an env var or documenting it in a .env.example.


Minor Notes

  • The polling uses sleep(1000) in a retry/backoff loop, which is acceptable (retry/reconnect backoff is an explicitly listed valid use case).
  • The 120-iteration / 2-minute timeout is a reasonable upper bound for a local dev server.
  • concurrently -n server,vite,configure label count now matches the command count.

Summary

The intent is clear and the overall approach is sound. Main asks before merging:

  1. Extract the inline configure script to a dedicated file.
  2. Log (do not silently swallow) caught errors in the polling loop.
  3. Clarify whether dev:serverless also needs VITE_RIVET_ENDPOINT, and document the 6420 port.

@NathanFlurry NathanFlurry marked this pull request as ready for review May 5, 2026 11:24
Base automatically changed from 05-04-chore_rivetkit_admission_logic_todos to main May 5, 2026 14:58
@NathanFlurry NathanFlurry merged commit 7640323 into main May 5, 2026
22 of 24 checks passed
@NathanFlurry NathanFlurry deleted the 05-04-wip_kitchen_sink_agentic_loop_finish branch May 5, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant