chore: update comment#4966
Conversation
|
🚅 Deployed to the rivet-pr-4966 environment in rivet-frontend
|
Code Review: chore: update commentOverviewThis PR adds a 3-line comment block above the FeedbackPositive
Style note (minor)
The current text uses a dash-separated structure: # "line-tables-only" produces just the line-number DWARF needed for stack
# traces, skipping variable/type info. Meaningfully faster debug builds
# (~2 min per engine cross-compile) with no runtime cost.A cleaner rewrite: # "line-tables-only" produces only the line-number DWARF needed for stack
# traces and skips variable and type info. This makes debug builds
# meaningfully faster (roughly 2 min per engine cross-compile) with no
# runtime cost.This is a minor style nit and not a blocker. SummaryTiny, helpful change. The only callout is the comment style not quite matching project conventions. Otherwise LGTM. |
Preview packages published to npmInstall with: npm install rivetkit@pr-4966All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-4b8e773
docker pull rivetdev/engine:full-4b8e773Individual packagesnpm install rivetkit@pr-4966
npm install @rivetkit/react@pr-4966
npm install @rivetkit/rivetkit-napi@pr-4966
npm install @rivetkit/workflow-engine@pr-4966 |
54bc0b3 to
1d1ad71
Compare
1d1ad71 to
b79cd59
Compare
e1be3d6 to
accd683
Compare
Merge activity
|

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: