Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,7 @@ fn parse_bridge_rivet_error(reason: &str) -> Option<anyhow::Error> {
return None;
}
};
tracing::warn!(
tracing::debug!(
group = %payload.group.as_str(),
code = %payload.code.as_str(),
message = %payload.message.as_str(),
Expand Down
13 changes: 9 additions & 4 deletions rivetkit-typescript/packages/rivetkit/src/registry/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,16 @@ export class Registry<A extends RegistryActors> {
}

const cancelToken = runtime.createCancellationToken();
// Metadata polls are synchronous GETs that complete immediately.
// Skip abort listener wiring to avoid per-poll event listener churn.
const needsAbortListener = !isMetadataRequest || isEngineMetadataRequest;
const abort = () => runtime.cancelCancellationToken(cancelToken);
if (request.signal.aborted) {
abort();
} else {
request.signal.addEventListener("abort", abort, { once: true });
if (needsAbortListener) {
if (request.signal.aborted) {
abort();
} else {
request.signal.addEventListener("abort", abort, { once: true });
}
}

const requestBody = await request.arrayBuffer();
Expand Down
22 changes: 18 additions & 4 deletions rivetkit-typescript/packages/rivetkit/src/registry/native.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2814,10 +2814,24 @@ export class ActorContextHandleAdapter {
let registered = false;
const trackedPromise = Promise.resolve(promise)
.catch((error) => {
logger().warn({
msg: "keepAwake promise rejected",
error: stringifyError(error),
});
// Queue timeouts and actor aborts are expected during graceful
// shutdown or normal polling loops. Only warn on unexpected errors.
const isBenign =
isRivetErrorLike(error) &&
((error.group === "queue" && error.code === "timed_out") ||
(error.group === "actor" && error.code === "aborted"));
if (isBenign) {
logger().debug({
msg: "keepAwake promise rejected (benign)",
group: error.group,
code: error.code,
});
} else {
logger().warn({
msg: "keepAwake promise rejected",
error: stringifyError(error),
});
}
})
.finally(async () => {
if (!registered) {
Expand Down
Loading