Skip to content

feat(website): add compute to sitemap#5099

Merged
abcxff merged 1 commit into
mainfrom
05-23-feat_website_add_compute_to_sitemap
May 23, 2026
Merged

feat(website): add compute to sitemap#5099
abcxff merged 1 commit into
mainfrom
05-23-feat_website_add_compute_to_sitemap

Conversation

@abcxff
Copy link
Copy Markdown
Contributor

@abcxff abcxff commented May 23, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5099 May 23, 2026 20:47 Destroyed
@railway-app
Copy link
Copy Markdown

railway-app Bot commented May 23, 2026

🚅 Deployed to the rivet-pr-5099 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web May 23, 2026 at 8:58 pm
frontend-cloud 😴 Sleeping (View Logs) Web May 23, 2026 at 8:56 pm
ladle ✅ Success (View Logs) Web May 23, 2026 at 8:51 pm
mcp-hub ✅ Success (View Logs) Web May 23, 2026 at 8:49 pm
frontend-inspector ❌ Build Failed (View Logs) Web May 23, 2026 at 8:48 pm
kitchen-sink ❌ Build Failed (View Logs) Web May 23, 2026 at 8:47 pm

Copy link
Copy Markdown
Contributor Author

abcxff commented May 23, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 23, 2026

Code Review

Overview

This PR removes a filter that was excluding the Rivet Compute deploy option (name: "rivet") from the sidebar navigation on the Connect/Platforms section of the docs site. The change is minimal (1 line) and allows /docs/connect/rivet-compute to appear in the sidebar alongside other deployment platform options.


Code Quality

The change itself is correct and clean. The target page (website/src/content/docs/connect/rivet-compute.mdx) exists, and the deployOptions entry in frontend/packages/shared-data/src/deploy.ts is fully populated with displayName, href, icon, and badge.


Observations

  • Why was it filtered in the first place? There's no comment or commit note explaining why rivet was excluded. If it was a temporary hold (page not ready, not publicly available yet), this PR should confirm that the content is now production-ready. If there's no reason for the original exclusion, the history is just noise — not a blocker, but worth noting.

  • PR description is unfilled. The PR body is the default template with no checkboxes ticked and no description. For a single-line docs/sitemap change this is low risk, but it's worth filling out per the project's contribution checklist.


Potential Issues

None. The page exists, the data is defined correctly, and the change is a pure removal of an exclusion filter with no side effects.


Verdict

LGTM. The change is correct and safe to merge.

@abcxff abcxff marked this pull request as ready for review May 23, 2026 20:50
Copy link
Copy Markdown
Contributor Author

abcxff commented May 23, 2026

Merge activity

  • May 23, 8:59 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 23, 8:59 PM UTC: @abcxff merged this pull request with Graphite.

@abcxff abcxff merged commit 14c5b35 into main May 23, 2026
12 of 17 checks passed
@abcxff abcxff deleted the 05-23-feat_website_add_compute_to_sitemap branch May 23, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant