Skip to content

refactor(frontend): runner_pool -> rivet_pool#5107

Merged
jog1t merged 1 commit into
mainfrom
05-27-refactor_frontend_runner_pool_-_rivet_pool
May 26, 2026
Merged

refactor(frontend): runner_pool -> rivet_pool#5107
jog1t merged 1 commit into
mainfrom
05-27-refactor_frontend_runner_pool_-_rivet_pool

Conversation

@jog1t
Copy link
Copy Markdown
Contributor

@jog1t jog1t commented May 26, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Contributor Author

jog1t commented May 26, 2026

Merge activity

  • May 26, 10:23 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 26, 10:35 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 26, 10:35 PM UTC: @jog1t merged this pull request with Graphite.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 26, 2026

Code Review: refactor(frontend): runner_pool -> rivet_pool

Overview

This is a minimal one-line fix that corrects the displayed environment variable name in the frontend UI from RUNNER_POOL to RIVET_POOL in frontend/src/app/env-variables.tsx. The rest of the codebase already uses RIVET_POOL consistently (runtime, examples, docs, tests), so this was the only stale reference.


Code Quality

  • Correct: The fix aligns the UI display with the actual env var name used everywhere else (rivetkit-typescript/packages/rivetkit/src/utils/env-vars.ts, examples, Cloudflare/Supabase docs, etc.).
  • No regressions: The remaining RUNNER_POOL strings in the codebase are unrelated — they are internal Rust timing constants (RUNNER_POOL_ERROR_CHECK_DELAY / RUNNER_POOL_ERROR_CHECK_INTERVAL) in engine/packages/guard/src/routing/pegboard_gateway/mod.rs and do not affect env var naming.
  • Consistent with getting-started.tsx and use-railway-template-link.ts, both of which already use RIVET_POOL.

Suggestions

  • PR description is empty. The boilerplate checklist was left unchecked and no description was filled in. While the change is self-evident, it is good practice to briefly note what was wrong and confirm it was tested.
  • No test coverage needed for a display-string fix, but a quick manual check that the env variables panel renders RIVET_POOL would be worth noting in the PR body.

Verdict

LGTM. The change is correct, complete, and consistent with the rest of the codebase. Minor process nit: fill in the PR description.

@jog1t jog1t changed the base branch from 05-27-refactor_frontend_modify_onboarding_for_rivet_compute to graphite-base/5107 May 26, 2026 22:32
@jog1t jog1t changed the base branch from graphite-base/5107 to main May 26, 2026 22:33
@jog1t jog1t force-pushed the 05-27-refactor_frontend_runner_pool_-_rivet_pool branch from 5548665 to 5e2ac07 Compare May 26, 2026 22:34
@jog1t jog1t merged commit 7f1d2b0 into main May 26, 2026
8 of 11 checks passed
@jog1t jog1t deleted the 05-27-refactor_frontend_runner_pool_-_rivet_pool branch May 26, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant