Skip to content

chore(website): redesign blog post page#5184

Merged
NicholasKissel merged 17 commits into
mainfrom
NicholasKissel/blog-redesign-ampcode
Jun 7, 2026
Merged

chore(website): redesign blog post page#5184
NicholasKissel merged 17 commits into
mainfrom
NicholasKissel/blog-redesign-ampcode

Conversation

@NicholasKissel
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 04:37 Destroyed
@railway-app
Copy link
Copy Markdown

railway-app Bot commented Jun 6, 2026

🚅 Deployed to the rivet-pr-5184 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Jun 6, 2026 at 8:57 pm
kitchen-sink ❌ Build Failed (View Logs) Web Jun 6, 2026 at 8:50 pm
frontend-cloud 😴 Sleeping (View Logs) Web Jun 6, 2026 at 7:56 am
ladle ✅ Success (View Logs) Web Jun 6, 2026 at 4:39 am
frontend-inspector ❌ Build Failed (View Logs) Web Jun 6, 2026 at 4:37 am
mcp-hub ✅ Success (View Logs) Web Jun 6, 2026 at 4:37 am

@NicholasKissel NicholasKissel marked this pull request as ready for review June 6, 2026 04:37
Copy link
Copy Markdown
Member Author

NicholasKissel commented Jun 6, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Jun 6, 2026

Blog Redesign Review

Overview: This PR consolidates the blog and changelog into a unified layout. Key changes: a new shared BlogArticle.astro component (eliminating ~494 lines of duplicate article rendering), a redesigned blog index showing changelog entries in a sticky sidebar calendar, and removal of the standalone /changelog/ index page (redirected to /blog).

The code reduction is real and the DRY approach is sound. A few items worth addressing before merge:


Bugs / Correctness

Back link hardcoded to /blog/ for changelog articles

In BlogArticle.astro line 71, the back link unconditionally navigates to /blog/, meaning changelog readers clicking Back land on the blog index instead of a changelog context. Since the section prop is already available, this should branch on it. The readNextBase variable already does this correctly for the Read next section.

Redirect does not cover trailing-slash variant

astro.config.mjs redirects /changelog to /blog, but /changelog/ (with trailing slash) is not listed. Pre-existing links to https://rivet.dev/changelog/ may 404 depending on how Astro handles trailing slash normalization. Worth verifying before merge.


Minor Issues

Indentation inconsistency in changelog calendar (blog/index.astro)

The opening <div> inside the changelogMonths.map(...) callback is not indented consistently with its closing tags. Cosmetic but stands out.

MONTHS constant duplicates browser capability

const MONTHS = [...] is a hand-rolled 12-element array. Since these are SSG pages, Intl.DateTimeFormat is available at build time and avoids the hardcoded list. If the project formatDate utility already handles month formatting, a shared helper would be cleaner.

from-black in overflow gradient

bg-gradient-to-t from-black in the changelog sidebar assumes a pure-black background. Using a CSS variable or from-zinc-950 would be more resilient if the page background shifts.

entry: any could be narrowed

The biome-ignore is acceptable, but Astro exposes CollectionEntry from astro:content. Replacing any removes the suppression comment and makes the component self-documenting.


Removed Features (confirm intentional)

  • Table of contents removed - The old layout rendered a DocsTableOfContents sidebar for long articles. The new BlogArticle.astro has no replacement. Worth confirming this is intentional for long-form posts.
  • Author attribution removed from article page - Author name, avatar, role, and social links were shown on the old article layout. The new component shows only the publication date. If author info should remain visible, this needs a follow-up.

Positive Notes

  • Section-aware Read next filtering is correctly implemented: changelog articles only surface other changelog items, blog articles only surface blog items.
  • Scoping global styles under .blog-article .blog-prose avoids leaking into docs pages.
  • Breadcrumb structured data added to the changelog article page is a good SEO improvement.
  • The sticky changelog sidebar with overflow scroll and gradient fade is a nice UX detail.

@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 04:44 Destroyed
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 06:15 Destroyed
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 18:46 Destroyed
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 19:11 Destroyed
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 19:15 Destroyed
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 19:22 Destroyed
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 19:24 Destroyed
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 19:28 Destroyed
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 19:34 Destroyed
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 19:40 Destroyed
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 19:53 Destroyed
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 20:12 Destroyed
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 20:24 Destroyed
@NicholasKissel NicholasKissel enabled auto-merge (squash) June 6, 2026 20:48
@NicholasKissel NicholasKissel force-pushed the NicholasKissel/blog-redesign-ampcode branch from 4f919e2 to 7bd4e1e Compare June 6, 2026 20:49
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5184 June 6, 2026 20:49 Destroyed
Copy link
Copy Markdown
Member Author

NicholasKissel commented Jun 7, 2026

Merge activity

  • Jun 7, 2:32 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 7, 2:32 AM UTC: @NicholasKissel merged this pull request with Graphite.

@NicholasKissel NicholasKissel merged commit 2d0f73f into main Jun 7, 2026
14 of 17 checks passed
@NicholasKissel NicholasKissel deleted the NicholasKissel/blog-redesign-ampcode branch June 7, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant