Skip to content

Commit 862387b

Browse files
NathanFlurryclaude
andauthored
fix(docker): don't leak FA Pro token into build logs (#149)
The ARG is already in the RUN environment, so the icons generate reads FONTAWESOME_PACKAGE_TOKEN directly instead of exporting it (which printed the token into Railway build logs). Build behaviour unchanged. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 8425e65 commit 862387b

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

website/Dockerfile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@ RUN apk add --no-cache git && npm install -g pnpm@9
1414
# in this discarded build stage — the final caddy image never contains it.
1515
ARG DOCS_THEME_SHA=450c498555135098c6a927adfdf13458be9be22a
1616
ARG FONTAWESOME_PACKAGE_TOKEN
17-
RUN export FONTAWESOME_PACKAGE_TOKEN="$FONTAWESOME_PACKAGE_TOKEN" \
18-
&& git clone https://github.com/rivet-dev/docs-theme.git /theme \
17+
# The ARG is already in this RUN's environment, so the icons generate reads
18+
# FONTAWESOME_PACKAGE_TOKEN directly — we don't echo it into the build log.
19+
RUN git clone https://github.com/rivet-dev/docs-theme.git /theme \
1920
&& git -C /theme checkout "$DOCS_THEME_SHA" \
2021
&& pnpm -C /theme install \
2122
&& pnpm -C /theme/packages/theme/vendor/icons run gen:manifest \

0 commit comments

Comments
 (0)