fix(wasm): only precreate-and-retry path_open on NOENT#243
Merged
NathanFlurry merged 1 commit intoJul 3, 2026
Merged
Conversation
The external-redirect fix (cd4683c) dropped the standalone-only gate on the precreate+retry block, so a sidecar-managed path_open that failed with EACCES got a precreate attempt and its errno replaced by the retry's result — a deny-write guest saw the wrong errno (caught by wasm_path_open_write_goes_through_kernel_filesystem_permissions when a warm runner was reused). Precreate-and-retry exists for creatable targets reported missing (`>>` append redirect targets), so gate it on the delegate returning NOENT; permission errors propagate untouched. Redirect regressions (wasm_shell_) and the wasm suite stay green.
Member
Author
|
Stack for rivet-dev/secure-exec
Get stack: |
railway-app
Bot
temporarily deployed
to
secure-exec / secure-exec-pr-243
NathanFlurry
deleted the
stack/fix-wasm-only-precreate-and-retry-path_open-on-noent-wsuvtsmm
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external-redirect fix (cd4683c) dropped the standalone-only gate on
the precreate+retry block, so a sidecar-managed path_open that failed
with EACCES got a precreate attempt and its errno replaced by the
retry's result — a deny-write guest saw the wrong errno (caught by
wasm_path_open_write_goes_through_kernel_filesystem_permissions when a
warm runner was reused). Precreate-and-retry exists for creatable
targets reported missing (
>>append redirect targets), so gate it onthe delegate returning NOENT; permission errors propagate untouched.
Redirect regressions (wasm_shell_) and the wasm suite stay green.