fix(utils): default value for defaults as objects#4637
Merged
heath-freenome merged 4 commits intorjsf-team:mainfrom May 30, 2025
Merged
fix(utils): default value for defaults as objects#4637heath-freenome merged 4 commits intorjsf-team:mainfrom
heath-freenome merged 4 commits intorjsf-team:mainfrom
Conversation
Member
8 tasks
Contributor
Author
|
@heath-freenome hello, so I tested the PR with my changes. It seems to work but requires to add some extra condition on my side, so I guess I'll wait for the PR to be merged first |
|
@foyarash I think @heath-freenome wants to merge yours first, actually :) |
Contributor
Author
Actually i think it should be fine for the arrays, my PR doesnt have any impact on form datas that are arrays. |
heath-freenome
approved these changes
May 30, 2025
nickgros
approved these changes
May 30, 2025
x0k
added a commit
to x0k/svelte-jsonschema-form
that referenced
this pull request
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fixes #4635
This PR fixes a situation where having a default set as an object, typically used for selects or radio buttons, would make the associated field frozen, with its value being impossible to change in the form.
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.