-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: add support for optgroups in SelectWidget and related documentation updates #5000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nlemoine
wants to merge
2
commits into
rjsf-team:main
Choose a base branch
from
nlemoine:feat/optgroup-select-widget
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+324
−21
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -644,6 +644,34 @@ render(<Form schema={schema} uiSchema={uiSchema} validator={validator} />, docum | |||||
|
|
||||||
| This property allows you to reorder the properties that are shown for a particular object. See [Objects](../json-schema/objects.md) for more information. | ||||||
|
|
||||||
| ### optgroups | ||||||
|
|
||||||
| To group `<option>` elements inside a `<select>` using `<optgroup>`, specify the grouping via the `optgroups` key in `ui:options`. Keys are the group labels, values are arrays of enum values belonging to that group. Any enum values not listed in a group are rendered ungrouped after the groups. | ||||||
|
|
||||||
| ```tsx | ||||||
| import { Form } from '@rjsf/core'; | ||||||
| import { RJSFSchema, UiSchema } from '@rjsf/utils'; | ||||||
| import validator from '@rjsf/validator-ajv8'; | ||||||
|
|
||||||
| const schema: RJSFSchema = { | ||||||
| type: 'string', | ||||||
| enum: ['lorem', 'ipsum', 'dolorem', 'alpha', 'beta', 'gamma'], | ||||||
| }; | ||||||
|
|
||||||
| const uiSchema: UiSchema = { | ||||||
| 'ui:options': { | ||||||
| optgroups: { | ||||||
| Latin: ['lorem', 'ipsum', 'dolorem'], | ||||||
| Greek: ['alpha', 'beta', 'gamma'], | ||||||
| }, | ||||||
| }, | ||||||
| }; | ||||||
|
|
||||||
| render(<Form schema={schema} uiSchema={uiSchema} validator={validator} />, document.getElementById('app')); | ||||||
| ``` | ||||||
|
|
||||||
| Currently supported by the `core` and `react-bootstrap` theme packages. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| ### placeholder | ||||||
|
|
||||||
| You can add placeholder text to an input by using the `ui:placeholder` uiSchema directive: | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks (nearly) identical to what you put into the
react-bootstrapcode. I would love for you to find a way to DRY up the two implementations. One approach could be to implement a component incorethat is a peer to theRichDescription/RichHelp/SchemaExamplescomponents and use it in both places. It likely would require passing props that are currently local variables. Let me know what you think is the best approach.