Apply nested const defaults through conditional allOf schemas#5132
Merged
heath-freenome merged 2 commits intoJun 26, 2026
Merged
Conversation
morgan-coded
force-pushed
the
fix/4963-nested-const-defaults
branch
from
61c1288 to
bbf0006
Compare
heath-freenome
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested
constAsDefaults: "always"values could be missed when the matching schema came through a conditionalallOf.Default form-state matching now resolves the conditional schema and uses the matched form data when applying nested object defaults. I checked the red-to-green regression, 693 focused utility tests,
cs-check, lint, the full suite with 1,404 passing and 100% coverage, andbuild:ts.Fixes #4963