Fix 4448: preserve empty string titles in oneOf/anyOf options list#5150
Open
thribhuvan003 wants to merge 2 commits into
Open
Fix 4448: preserve empty string titles in oneOf/anyOf options list#5150thribhuvan003 wants to merge 2 commits into
thribhuvan003 wants to merge 2 commits into
Conversation
|
|
||
| ## @rjsf/utils | ||
|
|
||
| - Fixed `optionsList()` to preserve an explicitly empty string `title` on `oneOf`/`anyOf` options instead of falling back to the option's value, fixing [#4448](https://github.com/rjsf-team/react-jsonschema-form/issues/4448) |
Member
There was a problem hiding this comment.
Can you put this at the end of the list of fixes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
optionsList()builds oneOf/anyOf option labels with||chains, so an explicitly empty string title ({ const: 'empty', title: '' }) is treated as missing and the label falls back to the const value. switched the fallbacks to??so an empty title is kept whileundefinedstill falls through to the schema title / value as before. added tests for the plain oneOf case and the discriminator path.fixes #4448
Checklist