Skip to content

Add grid layout feature#54

Merged
paulapreuss merged 37 commits into
mainfrom
feature/grid-layout
Jun 11, 2026
Merged

Add grid layout feature#54
paulapreuss merged 37 commits into
mainfrom
feature/grid-layout

Conversation

@paulapreuss

Copy link
Copy Markdown
Collaborator

No description provided.

@paulapreuss

Copy link
Copy Markdown
Collaborator Author

@bmlancien I have now added the grid layout page on this PR, you can go ahead and work on the design for the toolbar that we had discussed. Currently, the grid layout map has the following tools on the toolbar:

  • Fetch roads from OpenStreetMap
  • Draw line
  • Select all
  • Deselect all
  • Clear selected
    It looks very rudimentary now but the basic functionality I think will stay like this. The tools are defined in add_drawing_tools_to_map.js.

For consumer selection, it would be nice to then also have the drawing tools in the same style. These stay as they are now so:

  • Selection tools (Rectangle, polygon)
  • Add single marker
  • Add power house
  • Delete all

Let me know if you have any questions or want to have a chat about any of it :)

@bmlancien

Copy link
Copy Markdown
Collaborator

Thanks @paulapreuss
I will have a look at it and will come back to you if I have questions or if I'm finished :)

@bmlancien

Copy link
Copy Markdown
Collaborator

I only made a few changes. I was not able to make it exactly like in the mockups. It is probably possible technically, but might take some time to rearrange the items the exact way. But it is till a bit better, though.

  • Grouped the items into a single toolbox (kept zooming +/- separate)
  • Updated the icons and minor styling things
  • Put legend into a box
  • Fix legend text weight switching to bold when hovering on the toolbox (now it should stay as normal weight)

Is this okay for you this way or should I go on working on more details? Here you can see how the toolbar in the mockup was like.

Frame 230

@paulapreuss

Copy link
Copy Markdown
Collaborator Author

@bmlancien I saw via email notification that you commented here about the current state - I am not sure if you deleted the comment because you decided to continue working on it or if github swallowed your comment and it disappeared. Just let me know once you want me to have a look :)

@bmlancien

Copy link
Copy Markdown
Collaborator

@paulapreuss This is weird, because I still see my comment from 5 days ago. But anyway, yes please, have a look :)

@paulapreuss

paulapreuss commented May 27, 2026

Copy link
Copy Markdown
Collaborator Author

@paulapreuss This is weird, because I still see my comment from 5 days ago. But anyway, yes please, have a look :)

Now I see it too! Strange behavior indeed. Good thing I asked 😄 I do really like the mockup version, but it really depends on how much additional effort it would mean to get there. @KatLamm, I think you should probably weigh in here. Here is a screenshot of the current state (improved icon styling, description on hover as before)
grafik

@KatLamm

KatLamm commented May 28, 2026

Copy link
Copy Markdown

@bmlancien I agree with @paulapreuss "I do really like the mockup version, but it really depends on how much additional effort it would mean to get there". If the effort is "manageable/reasonable", then go ahead :)

@bmlancien

Copy link
Copy Markdown
Collaborator

@paulapreuss I pushed one commit to remove a duplicate function I haven't noticed last time. I will also create a new PR that you can merge into that branch if you want. This is about the styling of the toolbox. If prefer doing another PR because I'm not sure if this is not breaking the current functionality of the toolbox, since I'm not sure what is supposed to work or not (on my side at least not everything is working properly). So you can simply accept or not the PR.

I won't have much time next week to work on further improvements. I will only be available starting on June 8. I hope this is okay for you?

@bmlancien bmlancien mentioned this pull request May 29, 2026
@paulapreuss
paulapreuss force-pushed the feature/grid-layout branch 3 times, most recently from b2a139b to e9459f6 Compare June 11, 2026 13:56
@paulapreuss
paulapreuss marked this pull request as ready for review June 11, 2026 14:03
@paulapreuss
paulapreuss force-pushed the feature/grid-layout branch from 4208b00 to d9e04da Compare June 11, 2026 16:12
@paulapreuss
paulapreuss merged commit b0c00e9 into main Jun 11, 2026
2 checks passed
@paulapreuss
paulapreuss deleted the feature/grid-layout branch June 11, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to draw streets (as orientation for pole and grid positioning) in "consumer selection" page

4 participants