Add grid layout feature#54
Conversation
|
@bmlancien I have now added the grid layout page on this PR, you can go ahead and work on the design for the toolbar that we had discussed. Currently, the grid layout map has the following tools on the toolbar:
For consumer selection, it would be nice to then also have the drawing tools in the same style. These stay as they are now so:
Let me know if you have any questions or want to have a chat about any of it :) |
|
Thanks @paulapreuss |
|
@bmlancien I saw via email notification that you commented here about the current state - I am not sure if you deleted the comment because you decided to continue working on it or if github swallowed your comment and it disappeared. Just let me know once you want me to have a look :) |
|
@paulapreuss This is weird, because I still see my comment from 5 days ago. But anyway, yes please, have a look :) |
Now I see it too! Strange behavior indeed. Good thing I asked 😄 I do really like the mockup version, but it really depends on how much additional effort it would mean to get there. @KatLamm, I think you should probably weigh in here. Here is a screenshot of the current state (improved icon styling, description on hover as before) |
|
@bmlancien I agree with @paulapreuss "I do really like the mockup version, but it really depends on how much additional effort it would mean to get there". If the effort is "manageable/reasonable", then go ahead :) |
|
@paulapreuss I pushed one commit to remove a duplicate function I haven't noticed last time. I will also create a new PR that you can merge into that branch if you want. This is about the styling of the toolbox. If prefer doing another PR because I'm not sure if this is not breaking the current functionality of the toolbox, since I'm not sure what is supposed to work or not (on my side at least not everything is working properly). So you can simply accept or not the PR. I won't have much time next week to work on further improvements. I will only be available starting on June 8. I hope this is okay for you? |
b2a139b to
e9459f6
Compare
Now handled directly from UnifiedToolbar
Buttons handled in addDrawingToolsToConsumerMap and addDrawingToolsToGridMap
4208b00 to
d9e04da
Compare


No description provided.