Skip to content

Style map toolboxes#59

Closed
bmlancien wants to merge 29 commits into
feature/grid-layoutfrom
feature/map-toolbox-design
Closed

Style map toolboxes#59
bmlancien wants to merge 29 commits into
feature/grid-layoutfrom
feature/map-toolbox-design

Conversation

@bmlancien

Copy link
Copy Markdown
Collaborator

paulapreuss and others added 29 commits May 12, 2026 16:56
Extract map fetch functions from backend_communication.js into
map_api.js. Move consumer-specific draw logic and state helpers
(draw:created handler, add_single_consumer_to_array,
count_consumers, unique_map_elements) from
add_drawing_tools_to_map.js into consumer_selection.js so they
only load on the consumer page.

Add grid_design_map.js for grid-specific draw:created handler
and trash bin override. Move remove_marker_from_map to
integrate_map.js as shared utility.

Fix search input form-submit on grid_design by adding
event.preventDefault(). Fix trash bin to use late-binding arrow
function so grid page can override customTrashBinAction.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bmlancien bmlancien requested a review from paulapreuss May 29, 2026 14:25
@paulapreuss

Copy link
Copy Markdown
Collaborator

@paulapreuss I pushed one commit to remove a duplicate function I haven't noticed last time. I will also create a new PR that you can merge into that branch if you want. This is about the styling of the toolbox. If prefer doing another PR because I'm not sure if this is not breaking the current functionality of the toolbox, since I'm not sure what is supposed to work or not (on my side at least not everything is working properly). So you can simply accept or not the PR.

Sounds good! I will also have a look at all the functionality after the styling is done and fix anything that is broken. Also feel free to exchange the symbols I used so far for the tools, they were more like placeholders.

I won't have much time next week to work on further improvements. I will only be available starting on June 8. I hope this is okay for you?

Yes, that's fine, as the backend implementation of this feature also still needs some work anyway :)

@paulapreuss

Copy link
Copy Markdown
Collaborator

@bmlancien are you still working on this or is the feature finished from this side? I wasn't sure now. I noticed that the tooltips look the way we discussed from the styling, but that the boxes match the functions from the mockup and not the final version (e.g. we got rid of "Undo" for the actual implementation).

@bmlancien

Copy link
Copy Markdown
Collaborator Author

Hi @paulapreuss I haven't been working on this anymore. I must have mixed up the functionalities... You can either remove the ones that are not necessary anymore or tell me which ones I should remove, as I don't remember anymore.

@paulapreuss

Copy link
Copy Markdown
Collaborator

@bmlancien alright thanks! No problem, I'll take care of that, just wasn't sure if this was still WIP so didn't want to work in parallel :) thanks for the design implementation!

@paulapreuss paulapreuss force-pushed the feature/grid-layout branch 3 times, most recently from b2a139b to e9459f6 Compare June 11, 2026 13:56
@paulapreuss

Copy link
Copy Markdown
Collaborator

Specific commit cherry-picked and implemented directly in #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants