just few unit tests

Author: rluders

internal/controller/container.go

@@ -28,6 +28,8 @@ func init() {
 	containerService = service.NewContainerService(cli)
 }
 
+func setContainerServiceForTest(s service.ContainerService) { containerService = s }
+
 // Container represents a container's simplified information.
 type Container struct {
 	ID        string
@@ -318,6 +320,10 @@ func GetContainerStats(idOrName string) (stat ContainerStat, err error) {
 		return ContainerStat{}, err
 	}
 
+	return calculateStat(s), nil
+}
+
+func calculateStat(s statsJSON) ContainerStat {
 	cpuDelta := float64(s.CPUStats.CPUUsage.TotalUsage) - float64(s.PreCPUStats.CPUUsage.TotalUsage)
 	systemDelta := float64(s.CPUStats.SystemCPUUsage) - float64(s.PreCPUStats.SystemCPUUsage)
 	numCPUs := float64(s.CPUStats.OnlineCPUs)
@@ -339,7 +345,7 @@ func GetContainerStats(idOrName string) (stat ContainerStat, err error) {
 		CPUPercent: cpuPercent,
 		MemUsage:   memUsage,
 		MemLimit:   s.MemoryStats.Limit,
-	}, nil
+	}
 }
 
 // formatCreated parses a Docker RFC3339 created timestamp into a human-readable age.

internal/controller/container_test.go

@@ -0,0 +1,100 @@
+package controller
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/docker/docker/api/types/container"
+	clientmock "github.com/rluders/berth/mocks/client"
+	"github.com/rluders/berth/internal/service"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/mock"
+	"github.com/stretchr/testify/require"
+)
+
+func TestListContainers_returnsMappedContainers(t *testing.T) {
+	mockClient := clientmock.NewMockAPIClient(t)
+	mockClient.EXPECT().
+		ContainerList(mock.Anything, container.ListOptions{All: true}).
+		Return([]container.Summary{
+			{
+				ID:      "abcdef123456789",
+				Image:   "nginx:latest",
+				Command: "nginx -g 'daemon off;'",
+				Names:   []string{"/my-nginx"},
+				Status:  "Up 2 hours",
+				State:   "running",
+			},
+		}, nil)
+
+	setContainerServiceForTest(service.NewContainerService(mockClient))
+
+	result, err := ListContainers()
+
+	require.NoError(t, err)
+	require.Len(t, result, 1)
+	assert.Equal(t, "abcdef123456", result[0].ID) // truncated to 12
+	assert.Equal(t, "nginx:latest", result[0].Image)
+	assert.Equal(t, "my-nginx", result[0].Names) // leading / stripped
+	assert.Equal(t, "running", result[0].State)
+}
+
+func TestListContainers_propagatesError(t *testing.T) {
+	mockClient := clientmock.NewMockAPIClient(t)
+	mockClient.EXPECT().
+		ContainerList(mock.Anything, container.ListOptions{All: true}).
+		Return(nil, errors.New("connection refused"))
+
+	setContainerServiceForTest(service.NewContainerService(mockClient))
+
+	_, err := ListContainers()
+	assert.ErrorContains(t, err, "connection refused")
+}
+
+func TestStartContainer_callsServiceWithID(t *testing.T) {
+	mockClient := clientmock.NewMockAPIClient(t)
+	mockClient.EXPECT().
+		ContainerStart(mock.Anything, "abc123", container.StartOptions{}).
+		Return(nil)
+
+	setContainerServiceForTest(service.NewContainerService(mockClient))
+
+	err := StartContainer("abc123")
+	assert.NoError(t, err)
+}
+
+func TestStopContainer_callsServiceWithID(t *testing.T) {
+	mockClient := clientmock.NewMockAPIClient(t)
+	mockClient.EXPECT().
+		ContainerStop(mock.Anything, "abc123", container.StopOptions{}).
+		Return(nil)
+
+	setContainerServiceForTest(service.NewContainerService(mockClient))
+
+	err := StopContainer("abc123")
+	assert.NoError(t, err)
+}
+
+func TestRestartContainer_callsServiceWithID(t *testing.T) {
+	mockClient := clientmock.NewMockAPIClient(t)
+	mockClient.EXPECT().
+		ContainerRestart(mock.Anything, "abc123", container.StopOptions{}).
+		Return(nil)
+
+	setContainerServiceForTest(service.NewContainerService(mockClient))
+
+	err := RestartContainer("abc123")
+	assert.NoError(t, err)
+}
+
+func TestRemoveContainer_callsServiceWithForce(t *testing.T) {
+	mockClient := clientmock.NewMockAPIClient(t)
+	mockClient.EXPECT().
+		ContainerRemove(mock.Anything, "abc123", container.RemoveOptions{Force: true}).
+		Return(nil)
+
+	setContainerServiceForTest(service.NewContainerService(mockClient))
+
+	err := RemoveContainer("abc123")
+	assert.NoError(t, err)
+}

internal/controller/format_test.go

@@ -0,0 +1,68 @@
+package controller
+
+import (
+	"fmt"
+	"testing"
+	"time"
+
+	"github.com/docker/docker/api/types/container"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestFormatPorts(t *testing.T) {
+	tests := []struct {
+		name  string
+		ports []container.Port
+		want  string
+	}{
+		{"empty", nil, ""},
+		{"single exposed port no binding", []container.Port{{PrivatePort: 80, Type: "tcp"}}, "80/tcp"},
+		{"single port with public binding", []container.Port{{PrivatePort: 80, PublicPort: 8080, Type: "tcp"}}, "8080->80/tcp"},
+		{"duplicate ports deduplicated", []container.Port{
+			{PrivatePort: 80, Type: "tcp"},
+			{PrivatePort: 80, Type: "tcp"},
+		}, "80/tcp"},
+		{"multiple distinct ports", []container.Port{
+			{PrivatePort: 80, Type: "tcp"},
+			{PrivatePort: 443, Type: "tcp"},
+		}, "80/tcp, 443/tcp"},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := formatPorts(tt.ports)
+			assert.Equal(t, tt.want, got)
+		})
+	}
+}
+
+func TestFormatCreated(t *testing.T) {
+	t.Run("invalid string returned as-is", func(t *testing.T) {
+		got := formatCreated("not-a-timestamp")
+		assert.Equal(t, "not-a-timestamp", got)
+	})
+
+	t.Run("30 seconds ago", func(t *testing.T) {
+		ts := time.Now().Add(-30 * time.Second).Format(time.RFC3339Nano)
+		got := formatCreated(ts)
+		assert.Equal(t, "30s ago", got)
+	})
+
+	t.Run("5 minutes ago", func(t *testing.T) {
+		ts := time.Now().Add(-5 * time.Minute).Format(time.RFC3339Nano)
+		got := formatCreated(ts)
+		assert.Equal(t, "5m ago", got)
+	})
+
+	t.Run("3 hours ago", func(t *testing.T) {
+		ts := time.Now().Add(-3 * time.Hour).Format(time.RFC3339Nano)
+		got := formatCreated(ts)
+		assert.Equal(t, "3h ago", got)
+	})
+
+	t.Run("2 days ago", func(t *testing.T) {
+		ts := time.Now().Add(-48 * time.Hour).Format(time.RFC3339Nano)
+		got := formatCreated(ts)
+		assert.Equal(t, fmt.Sprintf("%dd ago", 48/24), got)
+	})
+}