Skip to content

Commit ca35ecf

Browse files
committed
Simplify health checking logic
1 parent d9ceb98 commit ca35ecf

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

backend/api/src/main/kotlin/org/rm3l/devfeed/actuator/DevFeedHealthChecker.kt

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,27 @@
2525
package org.rm3l.devfeed.actuator
2626

2727
import org.rm3l.devfeed.persistence.DevFeedDao
28+
import org.slf4j.LoggerFactory
2829
import org.springframework.boot.actuate.health.Health
2930
import org.springframework.boot.actuate.health.HealthIndicator
3031
import org.springframework.stereotype.Service
3132

3233
@Service
3334
class DevFeedHealthChecker(private val dao: DevFeedDao) : HealthIndicator {
3435

36+
companion object {
37+
@JvmStatic private val logger = LoggerFactory.getLogger(DevFeedHealthChecker::class.java)
38+
}
39+
3540
override fun health(): Health =
36-
if (dao.getArticles(limit = 1).isNotEmpty()) {
41+
try {
42+
dao.checkHealth()
3743
Health.up().build()
38-
} else {
44+
} catch (e: Exception) {
45+
logger.warn("Application down due to the following health check error: ${e.message}")
46+
if (logger.isDebugEnabled) {
47+
logger.debug(e.message, e)
48+
}
3949
Health.down().build()
4050
}
4151
}

0 commit comments

Comments
 (0)