added "secondaryFuzzing" support, to allow customized post-processing#310
Open
horscroft-swish wants to merge 2 commits into
Open
added "secondaryFuzzing" support, to allow customized post-processing#310horscroft-swish wants to merge 2 commits into
horscroft-swish wants to merge 2 commits into
Conversation
|
This could be very useful. Is there any progress on this? Thanks. |
Author
|
It's a really simple PR, I don't know what else is necessary -- it
basically just gives the option to supply a "last mile processing" step
called secondaryFuzzing.
If there is anything you need to change, I'm all ears, but it should be
ready to merge in.
…On Sun, May 30, 2021 at 2:49 PM Filip Halaxa ***@***.***> wrote:
This could be very useful. Is there any progress on this? Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#310 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANRR7YTYGP55OGU7PJDTCLTQIX5FANCNFSM4CTLMDXQ>
.
|
|
I agree :) What about @rmm5t? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A common problem we've encountered in our applications is that we sometimes need less granularity in recent dates.
For example, a task assigned for today, noon, needs to be displayed as "Today" rather than "23 minutes from now", since most tasks are time-agnostic.
For our own purposes, I've added support for post-processing by supplying a function as a timeago setting:
$.timeago.settings.secondaryFuzzing = function(element, intendedText, difference) {}Which then applies necessary post-processing based on things such as element class, difference etc.
I figured it might be a useful use-case for the original codebase.