Skip to content

Commit 34e44ac

Browse files
committed
Fix specs
1 parent 2cae008 commit 34e44ac

2 files changed

Lines changed: 14 additions & 5 deletions

File tree

spec/graphql/tracing/detailed_trace/active_record_backend_spec.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
require "spec_helper"
33
require_relative "./backend_assertions"
44

5-
ActiveRecord::Base.logger = Logger.new($stdout)
65
if testing_rails?
76
describe GraphQL::Tracing::DetailedTrace::ActiveRecordBackend do
87
include GraphQLTracingDetailedTraceBackendAssertions

spec/graphql/tracing/detailed_trace_spec.rb

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,23 @@ def self.detailed_trace?(query)
4444
SamplerSchema.detailed_trace.delete_all_traces
4545
end
4646

47-
it "raises when no storage is configured" do
48-
err = assert_raises ArgumentError do
49-
Class.new(GraphQL::Schema) do
47+
if testing_rails?
48+
it "defaults to ActiveRecord" do
49+
schema = Class.new(GraphQL::Schema) do
5050
use GraphQL::Tracing::DetailedTrace
5151
end
52+
53+
assert_instance_of GraphQL::Tracing::DetailedTrace::ActiveRecordBackend, schema.detailed_trace.instance_variable_get(:@storage)
54+
end
55+
else
56+
it "raises when no storage is configured" do
57+
err = assert_raises ArgumentError do
58+
Class.new(GraphQL::Schema) do
59+
use GraphQL::Tracing::DetailedTrace
60+
end
61+
end
62+
assert_equal "To store traces, install ActiveRecord or provide `redis: ...`", err.message
5263
end
53-
assert_equal "Pass `redis: ...` to store traces in Redis for later review", err.message
5464
end
5565

5666
it "calls detailed_profile? on a Multiplex" do

0 commit comments

Comments
 (0)