Merge pull request #5505 from rmosolgo/fix-engine-routes

Lazily define engine routes using routes do ... end

Author: rmosolgo

lib/graphql.rb

@@ -126,7 +126,10 @@ class << self
   autoload :Testing, "graphql/testing"
   autoload :Current, "graphql/current"
   if defined?(::Rails::Engine)
-    autoload :Dashboard, 'graphql/dashboard'
+    # This needs to be defined before Rails runs `add_routing_paths`,
+    # otherwise GraphQL::Dashboard's routes won't have been gathered for loading
+    # when that initializer runs.
+    require 'graphql/dashboard'
   end
 end
 

lib/graphql/dashboard.rb

@@ -34,7 +34,7 @@ module Graphql
   class Dashboard < Rails::Engine
     engine_name "graphql_dashboard"
     isolate_namespace(Graphql::Dashboard)
-    routes.draw do
+    routes do
       root "landings#show"
       resources :statics, only: :show, constraints: { id: /[0-9A-Za-z\-.]+/ }
 
@@ -76,6 +76,8 @@ class Dashboard < Rails::Engine
         resources :subscriptions, only: [:show], constraints: { id: /[a-zA-Z0-9\-]+/ }
         post "/subscriptions/clear_all", to: "subscriptions#clear_all", as: :clear_all
       end
+
+      ApplicationController.include(Dashboard.routes.url_helpers)
     end
 
     class ApplicationController < ActionController::Base