Exec-next: Implement GraphQL::Current.field

Author: rmosolgo

lib/graphql/current.rb

@@ -41,7 +41,13 @@ def self.operation_name
     # @see GraphQL::Field#path for a string identifying this field
     # @return [GraphQL::Field, nil] The currently-running field, if there is one.
     def self.field
-      Fiber[:__graphql_runtime_info]&.values&.first&.current_field
+      if (interpreter_info = Fiber[:__graphql_runtime_info])
+        interpreter_info.values&.first&.current_field
+      elsif (field = Fiber[:__graphql_current_field])
+        field
+      else
+        nil
+      end
     end
 
     # @return [Class, nil] The currently-running {Dataloader::Source} class, if there is one.

lib/graphql/execution/field_resolve_step.rb

@@ -50,6 +50,7 @@ def append_selection(ast_node)
 
       def value
         query = @selections_step.query
+        set_current_field
         query.current_trace.begin_execute_field(@field_definition, @arguments, @field_results, query)
         sync(@field_results)
         query.current_trace.end_execute_field(@field_definition, @arguments, @field_results, query, @field_results)
@@ -76,6 +77,7 @@ def sync(lazy)
       end
 
       def call
+        set_current_field if @field_definition
         if @enqueued_authorization
           enqueue_next_steps
         elsif @finish_extension_idx
@@ -121,6 +123,7 @@ def build_arguments
         query = @selections_step.query
         field_name = @ast_node.name
         @field_definition = query.types.field(@parent_type, field_name) || raise(GraphQL::Error, "No field definition found for #{@parent_type.to_type_signature}.#{ast_node.name} (at #{@ast_node.position})")
+        set_current_field
         @arguments, errors = @runner.input_values[query].argument_values(@field_definition, @ast_node.arguments, self) # rubocop:disable Development/ContextIsPassedCop
         if errors
           build_errors_result(errors, nil)
@@ -552,6 +555,10 @@ def add_non_null_error(is_from_array)
         @runner.schema.type_error(err, @selections_step.query.context)
       end
 
+      def set_current_field
+        Fiber[:__graphql_current_field] = @field_definition
+      end
+
       private
 
       def build_graphql_result(graphql_result, key, field_result, return_type, is_nn, is_list, is_from_array) # rubocop:disable Metrics/ParameterLists

lib/graphql/execution/load_argument_step.rb

@@ -14,6 +14,7 @@ def initialize(field_resolve_step:, arguments:, load_receiver:, argument_value:,
       end
 
       def value
+        @field_resolve_step.set_current_field
         schema = @field_resolve_step.runner.schema
         @loaded_value = schema.sync_lazy(@loaded_value)
         assign_value
@@ -37,6 +38,7 @@ def value
       end
 
       def call
+        @field_resolve_step.set_current_field
         context = @field_resolve_step.selections_step.query.context
         @loaded_value = begin
           @load_receiver.load_and_authorize_application_object(@argument_definition, @argument_value, context)

lib/graphql/execution/prepare_object_step.rb

@@ -19,6 +19,7 @@ def initialize(object:, runner:, graphql_result:, key:, is_non_null:, field_reso
       end
 
       def value
+        @field_resolve_step.set_current_field
         if @authorized_value
           query = @field_resolve_step.selections_step.query
           query.current_trace.begin_authorized(@resolved_type, @object, query.context)
@@ -39,6 +40,7 @@ def value
       end
 
       def call
+        @field_resolve_step.set_current_field
         case @next_step
         when :resolve_type
           static_type = @field_resolve_step.static_type

spec/graphql/current_spec.rb

@@ -24,12 +24,16 @@ def fetch(names)
         end
       end
       class Thing < GraphQL::Schema::Object
-        field :name, String
+        field :name, String, resolve_static: :get_name
 
-        def name
+        def self.get_name(context)
           context[:current_field] << GraphQL::Current.field.path
           context.dataload(ThingSource, context, "thing")
         end
+
+        def name
+          self.class.get_name(context)
+        end
       end
       class Query < GraphQL::Schema::Object
         field :thing, Thing, resolve_static: true
@@ -49,7 +53,6 @@ def thing
     end
 
     it "returns execution information" do
-      exec_next_TODO("not implemented yet")
       ctx = {
         current_field: [],
         current_source: [],

spec/integration/rails/query_logs_spec.rb

@@ -103,7 +103,6 @@ def exec_query(str)
     assert_equal "Fork", res["data"]["someThing"]["otherThing"]["name"]
     # These can appear in different orders in the SQL comment:
     assert_includes log, "current_graphql_operation:OtherThingName"
-    exec_next_TODO "Exec-next doesn't broadcast this info yet but it should"
     assert_includes log, "current_graphql_field:Query.someThing"
     assert_includes log, "current_graphql_field:Thing.otherThing"
   end